[jira] [Commented] (SENTRY-1471) TestHDFSIntegrationBase.java implements HDFS ACL checking and query verification incorrectly

["Anne Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15489405#comment-15489405 ] 

Anne Yu commented on SENTRY-1471:
---------------------------------

[~vspector@gmail.com], thanks for pointing out this issue. Since you've spent quite some time investigating the issue, do you have idea of after fix SENTRY-1471, why TestHDFSIntegrationAdvanced starts to fail? I guess this jira is meant to fix catch logic in verifyOnAllSubDirsHelper and verifyQuery APIs, but without fixing the test failures, this patch won't pass upstream-qa. Or do you have a jira filed already for real TestHDFSIntegrationAdvanced test failures? In that case, I can wait for it to be fixed.

> TestHDFSIntegrationBase.java implements HDFS ACL checking and query verification incorrectly
> --------------------------------------------------------------------------------------------
>
>                 Key: SENTRY-1471
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1471
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>            Reporter: Vadim Spector
>            Assignee: Anne Yu
>
> verifyOnAllSubDirsHelper() in TestHDFSIntegrationBase.java has a bug. When the number of failed retries exceeds max value (the "else" portion of "if (retry > 0)" statement, it erroneously assigns hasSucceeded = true. It means that verifyOnAllSubDirsHelper() never returns false.
> Once the problem was fixed in a local development branch, several tests in TestHDFSIntegrationAdvanced.java started failing. TestHDFSIntegrationEnd2End tests are still ok.
> Also, it is unfortunate that TestHDFSIntegrationBase() returns boolean instead of throwing the original AssertionError which contains information about expected vs. found ACL permissions - this information is invaluable for debugging. The fix is easy - the to-be-fixed "else" portion is inside the "catch (Throwable th)" clause, so it should just re-throw caught exception. This makes "hasSucceeded" variable unnecessary - verifyOnAllSubDirsHelper() should have "void" return type.
> The same problem exists in verifyQuery(), also  in TestHDFSIntegrationBase.java. The "else" clause of "if (retry > 0)" also assigns "isSucceeded = true;" leading to the same problem - it never fails. Suggested solution would be the same - just re-throw the exception. It will not only fix the problem, but also make debugging easier. Current code "Assert.assertTrue(isSucceeded);" throws away valuable information about the expected vs detected number of database rows.
> Note: the above problems were introduced by SENTRY-1454. Suggested fixes match the original code prior to SENTRY-1454.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)