You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by "jrgemignani (via GitHub)" <gi...@apache.org> on 2023/07/24 17:41:31 UTC
[GitHub] [age] jrgemignani opened a new pull request, #1081: Master to PostgreSQL version 14
jrgemignani opened a new pull request, #1081:
URL: https://github.com/apache/age/pull/1081
** PLEASE DO NOT MERGE ** until thoroughly reviewed and approved by all reviewers. Reviewers must state their approval as a comment in the thread below. Additionally, this merge needs to be appropriately squashed before merging.
PR for moving the master branch up to PostgreSQL version 14.
It contains all of the latest work in the master branch in addition to all of the changes made to go from PostgreSQL version 13 to 14. When this PR is merged the master will be the latest and on PostgreSQL version 14.
Everyone listed as a reviewer needs to review this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani merged pull request #1081: Master to PostgreSQL version 14
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani merged PR #1081:
URL: https://github.com/apache/age/pull/1081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] dehowef commented on pull request #1081: Master to PostgreSQL version 14
Posted by "dehowef (via GitHub)" <gi...@apache.org>.
dehowef commented on PR #1081:
URL: https://github.com/apache/age/pull/1081#issuecomment-1648675751
Looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] MuhammadTahaNaveed commented on a diff in pull request #1081: Master to PostgreSQL version 14
Posted by "MuhammadTahaNaveed (via GitHub)" <gi...@apache.org>.
MuhammadTahaNaveed commented on code in PR #1081:
URL: https://github.com/apache/age/pull/1081#discussion_r1272650666
##########
src/backend/parser/cypher_clause.c:
##########
@@ -4356,7 +4358,7 @@ static Node *make_qual(cypher_parsestate *cpstate,
args = list_make1(entity->expr);
- node = (Node *)makeFuncCall(qualified_name, args, -1);
+ node = (Node *)makeFuncCall(qualified_name, args, COERCE_EXPLICIT_CALL, -1);
Review Comment:
[formatting] exceeds 80
##########
src/backend/parser/cypher_clause.c:
##########
@@ -3167,7 +3169,7 @@ static List *make_join_condition_for_edge(cypher_parsestate *cpstate,
args = list_make3(left_id, right_id, entity->expr);
// add to quals
- quals = lappend(quals, makeFuncCall(qualified_func_name, args, -1));
+ quals = lappend(quals, makeFuncCall(qualified_func_name, args, COERCE_EXPLICIT_CALL, -1));
Review Comment:
[formatting] exceeds 80
##########
src/backend/executor/cypher_utils.c:
##########
@@ -254,7 +254,7 @@ HeapTuple insert_entity_tuple_cid(ResultRelInfo *resultRelInfo,
// Insert index entries for the tuple
if (resultRelInfo->ri_NumIndices > 0)
{
- ExecInsertIndexTuples(elemTupleSlot, estate, false, NULL, NIL);
+ ExecInsertIndexTuples(resultRelInfo, elemTupleSlot, estate, false, false, NULL, NIL);
Review Comment:
[formatting] exceeds 80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] eyab commented on pull request #1081: Master to PostgreSQL version 14
Posted by "eyab (via GitHub)" <gi...@apache.org>.
eyab commented on PR #1081:
URL: https://github.com/apache/age/pull/1081#issuecomment-1648775285
Looks good. Great work!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org