You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/31 14:00:57 UTC
[GitHub] [superset] geido opened a new pull request #18229: chore: POC for referencing Github code in Docusaurus
geido opened a new pull request #18229:
URL: https://github.com/apache/superset/pull/18229
### SUMMARY
This is a POC for referencing Github code in Docusaurus.
### AFTER
https://user-images.githubusercontent.com/60598000/151806961-03c821e4-27d1-4e0c-af06-5967e3db1121.mp4
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #18229: chore: POC for referencing Github code in Docusaurus
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #18229:
URL: https://github.com/apache/superset/pull/18229#issuecomment-1025797159
> I like the direction, but I am afraid about the maintenance of that solution in long term. We have a hard-coded commit ID (or git tag) and a hard-coded line number. This can be easily outdated:
>
> * the example will be updated and the commit IT will not be updated to point to the new code,
> * the reference will be updated with the new code, but the lines will not be changed, e.g. extended with an additional enter added.
>
> As for the first case, we may use the version identifier (git tag) instead of commit in the future. However, then the second case is then even more likely.
>
> To reduce this case scenario Apache Airflow uses comments in the referenced file ( https://github.com/apache/airflow/blob/main/docs/apache-airflow/tutorial_taskflow_api.rst ), predicable comment structure (tags eg. for examples is added before this is required in the documentation). It allows also check that references on CI.
Hey @ad-m you are perfectly right and we also share these concerns. However, for the time being, we are happy with this solution as the code references that we are looking to add do not change very often. We definitely would like to think of longer-term solutions and the Airflow solution seems well structured. I am pinging @villebro who also has some ideas on this topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido merged pull request #18229: chore: Reference Github code in Docusaurus
Posted by GitBox <gi...@apache.org>.
geido merged pull request #18229:
URL: https://github.com/apache/superset/pull/18229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #18229: chore: Reference Github code in Docusaurus
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #18229:
URL: https://github.com/apache/superset/pull/18229#issuecomment-1025902664
As the POC was successful I am removing the POC file and moving this PR to mergeable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ad-m commented on pull request #18229: chore: POC for referencing Github code in Docusaurus
Posted by GitBox <gi...@apache.org>.
ad-m commented on pull request #18229:
URL: https://github.com/apache/superset/pull/18229#issuecomment-1025786193
I like the direction, but I am afraid about the maintenance of that solution in long term. We have a hard-coded commit ID (or git tag) and a hard-coded line number. This can be easily outdated:
* the example will be updated and the commit IT will not be updated to point to the new code,
* the reference will be updated with the new code, but the lines will not be changed, e.g. extended with an additional enter added.
As for the first case, we may use the version identifier (git tag) instead of commit in the future. However, then the second case is then even more likely.
To reduce this case scenario Apache Airflow uses comments in the referenced file ( https://github.com/apache/airflow/blob/main/docs/apache-airflow/tutorial_taskflow_api.rst ), predicable comment structure (tags eg. for examples is added before this is required in the documentation). It allows also check that references on CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org