[jira] [Comment Edited] (SOLR-11895) Fix "no events available" message on logging tab

["Cassandra Targett (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-11895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337718#comment-16337718 ] 

Cassandra Targett edited comment on SOLR-11895 at 1/24/18 3:07 PM:
-------------------------------------------------------------------

At solr/webapp/web/partials/logging.html#L45, there is this bit of HTML:

{code}
      <tfoot>
        <tr ng-show="events.length==0">
          <td colspan="4">No Events available</td>
        </tr>
      </thead>
{code}

This is a mismatched element ({{<tfoot>}} closed by {{</thead}}), but that's not causing the problem. 

In solr/webapp/web/css/angular/logging.css#L179, there is this bit of CSS:

{code}
#content #logging #viewer .has-data tfoot
{
  display: none;
}
{code}

That {{.has-data}} is a class that's given to the table in the aforementioned {{logging.html}}, and since the {{<tfoot>}} is part of the same table, the rule says not to show the {{tfoot}} element at all. The construct {{hasData}} is a real JQuery function, but I can't see that it's being used here.

I think that we could simplify this quite a bit by removing the CSS rule - in my testing removing it makes the "No Events available" text appear, but it disappears as soon as there is a log event to show.

I also think we should remove the spinner since it indicates that something is in progress instead of what it was intended to convey, which is that a refresh is happening regularly to check for new log events.

I'll cook up a quick patch in a few minutes.


was (Author: ctargett):
At solr/webapp/web/partials/logging.html#L45, there is this bit of HTML:

{code}
      <tfoot>
        <tr ng-show="events.length==0">
          <td colspan="4">No Events available</td>
        </tr>
      </thead>
{code}

This is a mismatched element ({{<tfoot>}} closed by {{</thead}}), but that's not causing the problem. 

In solr/webapp/web/css/angular/logging.css#L179, there is this bit of CSS:

{code}
#content #logging #viewer .has-data tfoot
{
  display: none;
}
{code}

That {{.has-data}} is a class that's given to the table in the aforementioned {{logging.html}}, and since the {{<tfoot>}} is part of the same table, the rule says not to show the {{tfoot}} element at all. The construct {{hasData}} is a real JQuery function, but I can't see that it's being used here.

I think that we could simplify this quite a bit by removing the CSS rule - in my testing removing it makes the "No Events available" text appear, but it disappears as soon as there is a log event to show.

I also think we should remove the spinner since it indicates that something is in progress instead of what it was intended to convey, which is that a refresh is happening regularly to check for new log events.

> Fix "no events available" message on logging tab
> ------------------------------------------------
>
>                 Key: SOLR-11895
>                 URL: https://issues.apache.org/jira/browse/SOLR-11895
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Shawn Heisey
>            Priority: Major
>
> A properly running Solr server with a very clean configuration may have absolutely no messages logged at WARN or ERROR.  When this happens, clicking on the logging tab produces a screen with no messages and a spinning cursor, which looks like the page is hung.
> It has come to my attention that there is a "No events available" message already in the UI, but it doesn't work.  I can think of two ways to fix the problem:
>  * Fix the detection in the UI so that the "No events available" message actually works.  Also, the spinner could be removed.  The spinner is a big reason that the page looks broken.
>  * Solr could log a "startup complete" message at WARN so that there is always something to display.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org