[jira] [Updated] (BOOKKEEPER-89) Bookkeeper API changes for initial Bookkeeper release

["Ivan Kelly (Updated) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BOOKKEEPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Kelly updated BOOKKEEPER-89:
---------------------------------

    Attachment: BOOKKEEPER-89.diff

Implemented changes as in description. RecoveryCallback is still public as BookKeeperTools needs it. BookKeeperTools has been moved in to the client package.
                
> Bookkeeper API changes for initial Bookkeeper release
> -----------------------------------------------------
>
>                 Key: BOOKKEEPER-89
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-89
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>         Attachments: BOOKKEEPER-89.diff
>
>
> Changes are as follows.
> BookKeeper#createLedger, parameter is named passwd, "Key" used in LedgerHandle api
> BookKeeper#getBookieClient shouldn't be public
> BookKeeper#createComplete shouldn't be public
> BookKeeper#openComplete shouldn't be public
> BookKeeper#deleteComplete shouldn't be public
> BookKeeper#halt could be changed to close(), should throw a BKException
> LedgerHandle#getLedgerKey passwd is used in BookKeeper, should possibly be private
> LedgerHandle#getLedgerMetadata shouldn't be public
> LedgerHandle#getDigestManager shouldn't be public
> LedgerHandle#getDistributionSchedule shouldn't be public
> LedgerHandle#writeLedgerConfig shouldn't be public
> LedgerHandle#addEntry should return void, errors should go in an Exception
> LedgerHandle#readComplete should not be public
> LedgerHandle#addComplete should not be public
> LedgerHandle#readLastConfirmedCompelte should not be public
> LedgerHandle#closeComplete should not be public
> ASyncCallback#RecoverCallback shouldn't be public

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira