[GitHub] incubator-omid pull request #39: [OMID-105] When a tentative family deletion...

[yonigottesman <gi...@git.apache.org>]

Github user yonigottesman commented on a diff in the pull request:

    https://github.com/apache/incubator-omid/pull/39#discussion_r205961769
  
    --- Diff: hbase-client/src/main/java/org/apache/omid/transaction/SnapshotFilterImpl.java ---
    @@ -298,26 +291,62 @@ public CommitTimestamp locateCellCommitTimestamp(long cellStartTimestamp, long e
             return commitCache;
         }
     
    -    private void buildFamilyDeletionCache(List<Cell> rawCells, Map<String, List<Cell>> familyDeletionCache) {
    -
    +    private void buildFamilyDeletionCache(HBaseTransaction transaction, List<Cell> rawCells, Map<String, Long> familyDeletionCache, Map<Long, Long> commitCache, Map<String,byte[]> attributeMap) throws IOException {
             for (Cell cell : rawCells) {
                 if (CellUtil.matchingQualifier(cell, CellUtils.FAMILY_DELETE_QUALIFIER) &&
    --- End diff --
    
    If we can use java 8, filter rawCells with java stream.
    export 
    " if (CellUtil.matchingQualifier(cell, CellUtils.FAMILY_DELETE_QUALIFIER) &&...."
    to a function 
    isFamilyDeleteCell(Cell) in CellUtils and call it from stream filter



---