[GitHub] [incubator-nuttx] pussuw commented on pull request #5985: RISC-V: Combine 3 variables that depend on CPU amount into one

[GitBox <gi...@apache.org>]

pussuw commented on PR #5985:
URL: https://github.com/apache/incubator-nuttx/pull/5985#issuecomment-1088574503

   @xiaoxiang781216 can you take a look when you have time. I marked this as draft as it does not compile yet / needs fixing but the basic structure should be in place.
   
   The question I have:
   Do you think it's appropriate for me to force other RISC-V targets that use an IRQ stack to use the percpu structure, or should I wrap the IRQ stack getter, so that it can e.g.:
   
   ```
   uintptr_t riscv_irqstack(void):
   #if PERCPU_COMPILED
     return riscv_percpu_get_irqstack
   #else
     return (uintptr_t) &g_intstacktop;
   #endif
   ```
   
   Or something along those lines ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org