You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by "dschmidt (via GitHub)" <gi...@apache.org> on 2026/08/30 13:19:17 UTC
[PR] TIKA-4831: The icon of a GeoGebra tool is its thumbnail [tika]
dschmidt opened a new pull request, #3100:
URL: https://github.com/apache/tika/pull/3100
Follow-up to #3044: a tool file (`.ggt`) has no `geogebra_thumbnail.png`, but a tool can have an icon, stored in a directory with a generated name and referenced by the macro's `iconFile` attribute (File Format reference, ".ggt"). The parser now emits that icon as the tool's THUMBNAIL, and not a second time as a picture.
Order of preference is unchanged for the other files: the worksheet thumbnail, then the first slide thumbnail, then the tool icon. A worksheet with an embedded tool keeps its own thumbnail; the icon stays INLINE there.
I could not find a real `.ggt` with an icon anywhere public (GitHub does not index binaries, GeoGebra's site offers no tools for download), so the test builds one after the XML reference.
https://issues.apache.org/jira/browse/TIKA-4831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4831: The icon of a GeoGebra tool is its thumbnail [tika]
Posted by "THausherr (via GitHub)" <gi...@apache.org>.
THausherr merged PR #3100:
URL: https://github.com/apache/tika/pull/3100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4831: The icon of a GeoGebra tool is its thumbnail [tika]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3100:
URL: https://github.com/apache/tika/pull/3100#discussion_r3891585446
##########
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-miscoffice-module/src/main/java/org/apache/tika/parser/geogebra/GeoGebraParser.java:
##########
@@ -301,21 +305,24 @@ private static String stripLeadingZeros(String digits) {
* is set, the document metadata. A part that cannot be read or is not
* well-formed is recorded in the metadata and skipped.
*/
- private void parseGeoGebraXml(ZipFile zipFile, ZipArchiveEntry entry,
- XHTMLContentHandler xhtml, Metadata metadata,
- boolean documentMetadata, ParseContext context)
+ /**
+ * @return the icon files of the macros in the XML, in document order
+ */
Review Comment:
There are two consecutive Javadoc blocks before parseGeoGebraXml(). Only the last one will be associated with the method, which makes the earlier documentation easy to miss and can trigger Javadoc lint noise. Please merge them into a single Javadoc with both the description and the `@return` tag.
This issue also appears on line 385 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4831: The icon of a GeoGebra tool is its thumbnail [tika]
Posted by "dschmidt (via GitHub)" <gi...@apache.org>.
dschmidt commented on code in PR #3100:
URL: https://github.com/apache/tika/pull/3100#discussion_r3892319497
##########
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-miscoffice-module/src/main/java/org/apache/tika/parser/geogebra/GeoGebraParser.java:
##########
@@ -301,21 +305,24 @@ private static String stripLeadingZeros(String digits) {
* is set, the document metadata. A part that cannot be read or is not
* well-formed is recorded in the metadata and skipped.
*/
- private void parseGeoGebraXml(ZipFile zipFile, ZipArchiveEntry entry,
- XHTMLContentHandler xhtml, Metadata metadata,
- boolean documentMetadata, ParseContext context)
+ /**
+ * @return the icon files of the macros in the XML, in document order
+ */
Review Comment:
Merged into one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org