You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "leandron (via GitHub)" <gi...@apache.org> on 2023/04/25 09:44:18 UTC

[GitHub] [tvm] leandron commented on a diff in pull request #14707: [Keras][Bugfix] fix a bug about alpha attribute in LeakyReLU which lead to passes conflict

leandron commented on code in PR #14707:
URL: https://github.com/apache/tvm/pull/14707#discussion_r1176272842


##########
tests/python/frontend/keras/test_forward.py:
##########
@@ -209,6 +211,15 @@ def test_forward_activations(self, keras_mod):
             keras_model = keras_mod.models.Model(data, x)
             verify_keras_frontend(keras_model)
             verify_keras_frontend(keras_model, need_transpose=False, layout="NHWC")
+        # test invalid attribute alpha=None for LeakyReLU
+        if package_version.parse(keras_mod.__version__.split("-tf")[0]) <= package_version.parse(
+            "2.3.1"
+        ):

Review Comment:
   I think we can do that, as we are not very restrictive in terms of which Keras version we support. Some version validation is done so that we can update dependencies and keep CI running, but at some point, tests that only pass with ancient versions should be removed. That's the only case I see it is OK to add version checking within a test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org