[jira] [Commented] (CASSANDRA-14319) nodetool rebuild from DC lets you pass invalid datacenters

["Vinay Chella (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-14319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407169#comment-16407169 ] 

Vinay Chella commented on CASSANDRA-14319:
------------------------------------------

Hi Jon,

Are you looking for something like below when we provide invalid datacenter as an option to rebuild?
{code:java}
$ bin/nodetool rebuild no_dc
nodetool: Provided datacenter: no_dc is not a valid datacenter, available datacenters are: datacenter1, datacenter2
See 'nodetool help' or 'nodetool help <command>'.
$ 
{code}
And for
{quote}3. Ideally, we indicate which keyspaces are set to replicate to this DC and which aren't
{quote}
Are you referring {{this}} as the datacenter from where the {{rebuild}} command is being executed from or the one which is provided as an option (e.g., {{no_dc}} in above example)? if it is the later, invalid dc would not have any keyspaces, so what is expected for #3 in this scenario?

 

I am interested in working on this ticket. Can you assign this ticket to me? 

> nodetool rebuild from DC lets you pass invalid datacenters 
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-14319
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14319
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jon Haddad
>            Priority: Major
>             Fix For: 2.1.x, 2.2.x, 3.0.x, 3.11.x, 4.x
>
>
> If you pass an invalid datacenter to nodetool rebuild, you'll get an error like this:
> {code}
> Unable to find sufficient sources for streaming range (3074457345618258602,-9223372036854775808] in keyspace system_distributed
> {code}
> Unfortunately, this is a rabbit hole of frustration if you are using caps for your DC names and you pass in a lowercase DC name, or you just typo the DC.  
> Let's do the following:
> # Check the DC name that's passed in against the list of DCs we know about
> # If we don't find it, let's output a reasonable error, and list all the DCs someone could put in.
> # Ideally we indicate which keyspaces are set to replicate to this DC and which aren't



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org