You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2014/10/24 20:54:19 UTC
Review Request 27151: SQOOP-1619: Add unique name constraint for
configurable ( connectors and driver)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27151/
-----------------------------------------------------------
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see jira
Diffs
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 633e9df
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java de08261
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java ce1830e
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java b22dbd5
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java d4c4009
Diff: https://reviews.apache.org/r/27151/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27151: SQOOP-1619: Add unique name constraint for
configurable ( connectors and driver)
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27151/#review58451
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On Oct. 24, 2014, 9:46 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27151/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 9:46 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 633e9df
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java de08261
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java ce1830e
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java b22dbd5
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java d4c4009
>
> Diff: https://reviews.apache.org/r/27151/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27151: SQOOP-1619: Add unique name constraint for
configurable ( connectors and driver)
Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27151/#review58395
-----------------------------------------------------------
Ship it!
Ship It!
- Gwen Shapira
On Oct. 24, 2014, 9:46 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27151/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 9:46 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 633e9df
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java de08261
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java ce1830e
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java b22dbd5
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java d4c4009
>
> Diff: https://reviews.apache.org/r/27151/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27151: SQOOP-1619: Add unique name constraint for
configurable ( connectors and driver)
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27151/
-----------------------------------------------------------
(Updated Oct. 24, 2014, 2:46 p.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see jira
Diffs (updated)
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 633e9df
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java de08261
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java ce1830e
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java b22dbd5
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java d4c4009
Diff: https://reviews.apache.org/r/27151/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27151: SQOOP-1619: Add unique name constraint for
configurable ( connectors and driver)
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 24, 2014, 12:47 p.m., Gwen Shapira wrote:
> > This doesn't seem to compile?
> > [ERROR] /Users/gshapira/workspace/sqoop2/repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java:[20,66] error: ';' expected
fixed last minute typo before creating a ptch..
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27151/#review58336
-----------------------------------------------------------
On Oct. 24, 2014, 2:46 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27151/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 2:46 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 633e9df
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java de08261
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java ce1830e
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java b22dbd5
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java d4c4009
>
> Diff: https://reviews.apache.org/r/27151/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27151: SQOOP-1619: Add unique name constraint for
configurable ( connectors and driver)
Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27151/#review58336
-----------------------------------------------------------
This doesn't seem to compile?
[ERROR] /Users/gshapira/workspace/sqoop2/repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java:[20,66] error: ';' expected
- Gwen Shapira
On Oct. 24, 2014, 6:56 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27151/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 6:56 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 633e9df
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java de08261
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java ce1830e
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java b22dbd5
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java d4c4009
>
> Diff: https://reviews.apache.org/r/27151/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27151: SQOOP-1619: Add unique name constraint for
configurable ( connectors and driver)
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27151/
-----------------------------------------------------------
(Updated Oct. 24, 2014, 11:56 a.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see jira
Diffs (updated)
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 633e9df
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java de08261
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java ce1830e
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java b22dbd5
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java d4c4009
Diff: https://reviews.apache.org/r/27151/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj