[GitHub] [superset] hbruch commented on a change in pull request #17826: fix(deck.gl): update view state on property changes (#17720)

[GitBox <gi...@apache.org>]

hbruch commented on a change in pull request #17826:
URL: https://github.com/apache/superset/pull/17826#discussion_r776421602



##########
File path: superset-frontend/plugins/legacy-preset-chart-deckgl/src/DeckGLContainer.jsx
##########
@@ -64,6 +64,12 @@ export class DeckGLContainer extends React.Component {
     };
   }
 
+  UNSAFE_componentWillReceiveProps(nextProps) {
+    if (nextProps.viewport !== this.props.viewport) {

Review comment:
       Thanks for the hint. Is adressed by last commit (though checks failed again)... 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org