[jira] [Updated] (YUNIKORN-1905) instance type cleanup

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YUNIKORN-1905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated YUNIKORN-1905:
-------------------------------------
    Labels: newbie pull-request-available  (was: newbie)

> instance type cleanup
> ---------------------
>
>                 Key: YUNIKORN-1905
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1905
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: core - scheduler
>            Reporter: Wilfred Spiegelenburg
>            Assignee: PoAn Yang
>            Priority: Minor
>              Labels: newbie, pull-request-available
>
> While reviewing YUNIKORN-1888 I noticed that the changes for YUNIKORN-1889 can be pushed through even further.
> We still pull the instanceType in multiple locations and in the end overwrite it in the {{partition.allocate}} call. That is unneeded work we do in multiple places in the code.
> We should clean up further and rely on the partition to always set the instanceType for an allocation. Remove it from the call NewAllocation which means we can remove it from NewAllocationFromSI. 
> The partition allocate call is however not used when we initialise the system as we need to bypass certain checks for allocations that are already running. This means one extra location in the partition to handle that after YUNIKORN-1888 is done.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org