You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Scott Chen (Created) (JIRA)" <ji...@apache.org> on 2012/02/22 03:30:50 UTC

[jira] [Created] (HBASE-5441) HRegionThriftServer may not start due to a race-condition

HRegionThriftServer may not start due to a race-condition
---------------------------------------------------------

                 Key: HBASE-5441
                 URL: https://issues.apache.org/jira/browse/HBASE-5441
             Project: HBase
          Issue Type: Bug
          Components: thrift
            Reporter: Scott Chen
            Assignee: Scott Chen
            Priority: Minor


This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.

org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
        at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)

        at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
        at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
        at $Proxy8.getProtocolVersion(Unknown Source)
        at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
        at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
        at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
        at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
        at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
        at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
        at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
        at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
        at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
        at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
        at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
        at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
        at java.lang.Thread.run(Thread.java:662)
2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219245#comment-13219245 ] 

Zhihong Yu commented on HBASE-5441:
-----------------------------------

@Scott:
Patch v4 doesn't apply to ThriftServerRunner.java cleanly.
Do you mind regenerating a patch that applies to TRUNK cleanly ?

                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch, HBASE-5441.D1857.4.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Phabricator (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272659#comment-13272659 ] 

Phabricator commented on HBASE-5441:
------------------------------------

sc has closed the revision "HBASE-5441 [jira] HRegionThriftServer may not start because of a race-condition".

REVISION DETAIL
  https://reviews.facebook.net/D1857

To: tedyu, dhruba, JIRA, sc

                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: 5441-v5.txt, HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch, HBASE-5441.D1857.4.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Scott Chen (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Chen updated HBASE-5441:
------------------------------

    Summary: HRegionThriftServer may not start because of a race-condition  (was: HRegionThriftServer may not start due to a race-condition)
    
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216065#comment-13216065 ] 

Hadoop QA commented on HBASE-5441:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12515639/HBASE-5441.D1857.4.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1047//console

This message is automatically generated.
                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch, HBASE-5441.D1857.4.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HBASE-5441:
-------------------------------

    Attachment: HBASE-5441.D1845.1.patch

sc requested code review of "HBASE-5441 [jira] HRegionThriftServer may not start because of a race-condition".
Reviewers: tedyu, dhruba, JIRA

  HRegionThriftServer may not start because of a race-condition

  This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.

  org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
          at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)

          at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
          at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
          at $Proxy8.getProtocolVersion(Unknown Source)
          at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
          at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
          at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
          at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
          at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
          at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
          at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
          at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
          at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
          at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
          at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
          at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
          at java.lang.Thread.run(Thread.java:662)
  2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

TEST PLAN
  TBD

REVISION DETAIL
  https://reviews.facebook.net/D1845

AFFECTED FILES
  src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/3915/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HBASE-5441:
-------------------------------

    Attachment: HBASE-5441.D1857.3.patch

sc updated the revision "HBASE-5441 [jira] HRegionThriftServer may not start because of a race-condition".
Reviewers: tedyu, dhruba, JIRA

  Addressed the review comment from Dhruba. Thanks!

REVISION DETAIL
  https://reviews.facebook.net/D1857

AFFECTED FILES
  src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java

                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HBASE-5441:
-------------------------------

    Attachment: HBASE-5441.D1845.2.patch

sc updated the revision "HBASE-5441 [jira] HRegionThriftServer may not start because of a race-condition".
Reviewers: tedyu, dhruba, JIRA

  Fix a bug

REVISION DETAIL
  https://reviews.facebook.net/D1845

AFFECTED FILES
  src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java

                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213419#comment-13213419 ] 

Phabricator commented on HBASE-5441:
------------------------------------

sc has commented on the revision "HBASE-5441 [jira] HRegionThriftServer may not start because of a race-condition".

  The reason why this works is
  "JDK5 and later extends the semantics for volatile so that the system will not allow a write of a volatile to be reordered with respect to any previous read or write, and a read of a volatile cannot be reordered with respect to any following read or write."

  It is explained in
  http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html

REVISION DETAIL
  https://reviews.facebook.net/D1857

                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219366#comment-13219366 ] 

Zhihong Yu commented on HBASE-5441:
-----------------------------------

Patch v5 integrated to TRUNK.

Thanks for the patch Scott.

Thanks for the review Dhruba.
                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: 5441-v5.txt, HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch, HBASE-5441.D1857.4.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213554#comment-13213554 ] 

Hadoop QA commented on HBASE-5441:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12515545/HBASE-5441.D1857.3.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated -136 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 152 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.thrift.TestThriftServer
                  org.apache.hadoop.hbase.mapreduce.TestImportTsv
                  org.apache.hadoop.hbase.mapred.TestTableMapReduce
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
                  org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1008//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1008//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1008//console

This message is automatically generated.
                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213716#comment-13213716 ] 

Phabricator commented on HBASE-5441:
------------------------------------

tedyu has accepted the revision "HBASE-5441 [jira] HRegionThriftServer may not start because of a race-condition".

REVISION DETAIL
  https://reviews.facebook.net/D1857

BRANCH
  hb-5441

                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213400#comment-13213400 ] 

Phabricator commented on HBASE-5441:
------------------------------------

dhruba has commented on the revision "HBASE-5441 [jira] HRegionThriftServer may not start because of a race-condition".

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:501 every call will have to go via a synchronized section, will definitely slow down throughput. How about if we do the the 'volatile thing' described in http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html


  class Foo {
      private volatile Helper helper = null;
      public Helper getHelper() {
          Helper result = helper;
          if (result == null) {
              synchronized(this) {
                  result = helper;
                  if (result == null) {
                      helper = result = new Helper();
                  }
              }
          }
          return result;
      }

      // other functions and members...
  }

REVISION DETAIL
  https://reviews.facebook.net/D1857

                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HBASE-5441:
-------------------------------

    Attachment: HBASE-5441.D1857.2.patch

sc updated the revision "HBASE-5441 [jira] HRegionThriftServer may not start because of a race-condition".
Reviewers: tedyu, dhruba, JIRA

  Address Ted's review comment. Thanks!

REVISION DETAIL
  https://reviews.facebook.net/D1857

AFFECTED FILES
  src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java

                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213830#comment-13213830 ] 

Phabricator commented on HBASE-5441:
------------------------------------

sc has commented on the revision "HBASE-5441 [jira] HRegionThriftServer may not start because of a race-condition".

  Sorry. I synchronized on the wrong reference and I should have run the test before update the patch. I will update it soon.

REVISION DETAIL
  https://reviews.facebook.net/D1857

BRANCH
  hb-5441

                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213730#comment-13213730 ] 

Phabricator commented on HBASE-5441:
------------------------------------

tedyu has commented on the revision "HBASE-5441 [jira] HRegionThriftServer may not start because of a race-condition".

  Hadoop QA reported the following in test failures:

  java.lang.NullPointerException
  	at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.getHBaseAdmin(ThriftServerRunner.java:502)
  	at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.getTableNames(ThriftServerRunner.java:563)
  	at org.apache.hadoop.hbase.thrift.TestThriftServer.createTestTables(TestThriftServer.java:169)
  	at org.apache.hadoop.hbase.thrift.TestThriftServer.doTestTableCreateDrop(TestThriftServer.java:119)

REVISION DETAIL
  https://reviews.facebook.net/D1857

BRANCH
  hb-5441

                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "dhruba borthakur (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219383#comment-13219383 ] 

dhruba borthakur commented on HBASE-5441:
-----------------------------------------

Thanks for integrating it with trunk and committing it, Ted.
                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: 5441-v5.txt, HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch, HBASE-5441.D1857.4.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213282#comment-13213282 ] 

Phabricator commented on HBASE-5441:
------------------------------------

sc has commented on the revision "HBASE-5441 [jira] HRegionThriftServer may not start because of a race-condition".

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:497 Yes, I will remove this. Thanks for the comment.

  Double-check locking does not actually work:
  http://en.wikipedia.org/wiki/Double-checked_locking

  I will update the patch soon.

REVISION DETAIL
  https://reviews.facebook.net/D1845

                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhihong Yu updated HBASE-5441:
------------------------------

    Status: Patch Available  (was: Open)
    
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213232#comment-13213232 ] 

Phabricator commented on HBASE-5441:
------------------------------------

tedyu has commented on the revision "HBASE-5441 [jira] HRegionThriftServer may not start because of a race-condition".

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:497 How about adding synchronized to this method and remove double checking against null ?

REVISION DETAIL
  https://reviews.facebook.net/D1845

                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HBASE-5441:
-------------------------------

    Attachment: HBASE-5441.D1857.4.patch

sc updated the revision "HBASE-5441 [jira] HRegionThriftServer may not start because of a race-condition".
Reviewers: tedyu, dhruba, JIRA

  Synchronized on this instead of admin

REVISION DETAIL
  https://reviews.facebook.net/D1857

AFFECTED FILES
  src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java

                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch, HBASE-5441.D1857.4.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220256#comment-13220256 ] 

Hudson commented on HBASE-5441:
-------------------------------

Integrated in HBase-TRUNK #2671 (See [https://builds.apache.org/job/HBase-TRUNK/2671/])
    HBASE-5441 HRegionThriftServer may not start because of a race-condition (Scott Chen) (Revision 1295192)

     Result = FAILURE
tedyu : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java

                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: 5441-v5.txt, HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch, HBASE-5441.D1857.4.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213420#comment-13213420 ] 

Phabricator commented on HBASE-5441:
------------------------------------

dhruba has commented on the revision "HBASE-5441 [jira] HRegionThriftServer may not start because of a race-condition".

  Looks good to me. +1

REVISION DETAIL
  https://reviews.facebook.net/D1857

                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Phabricator (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272588#comment-13272588 ] 

Phabricator commented on HBASE-5441:
------------------------------------

dhruba has resigned from the revision "HBASE-5441 [jira] HRegionThriftServer may not start because of a race-condition".

REVISION DETAIL
  https://reviews.facebook.net/D1845

To: tedyu, JIRA, sc

                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: 5441-v5.txt, HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch, HBASE-5441.D1857.4.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Scott Chen (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219647#comment-13219647 ] 

Scott Chen commented on HBASE-5441:
-----------------------------------

Thanks for the review and commit, Ted.
                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: 5441-v5.txt, HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch, HBASE-5441.D1857.4.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhihong Yu updated HBASE-5441:
------------------------------

    Attachment: 5441-v5.txt

Patch v5 applies to TRUNK.
                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: 5441-v5.txt, HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch, HBASE-5441.D1857.4.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213413#comment-13213413 ] 

Phabricator commented on HBASE-5441:
------------------------------------

sc has commented on the revision "HBASE-5441 [jira] HRegionThriftServer may not start because of a race-condition".

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:501 I see. If the reference is volatile than it is OK. I will make the change again.

REVISION DETAIL
  https://reviews.facebook.net/D1857

                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213958#comment-13213958 ] 

Phabricator commented on HBASE-5441:
------------------------------------

tedyu has commented on the revision "HBASE-5441 [jira] HRegionThriftServer may not start because of a race-condition".

  Patch looks good.
  Will integrate after unit tests pass.

REVISION DETAIL
  https://reviews.facebook.net/D1857

BRANCH
  hb-5441

                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch, HBASE-5441.D1857.4.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhihong Yu updated HBASE-5441:
------------------------------

    Comment: was deleted

(was: @Scott:
Patch v4 doesn't apply to ThriftServerRunner.java cleanly.
Do you mind regenerating a patch that applies to TRUNK cleanly ?
)
    
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: 5441-v5.txt, HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch, HBASE-5441.D1857.4.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213985#comment-13213985 ] 

Zhihong Yu commented on HBASE-5441:
-----------------------------------

Latest test run is clean - no test regression.

Will integrate the patch tomorrow if I don't hear objection.
                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch, HBASE-5441.D1857.4.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhihong Yu updated HBASE-5441:
------------------------------

      Resolution: Fixed
    Hadoop Flags: Reviewed
          Status: Resolved  (was: Patch Available)
    
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: 5441-v5.txt, HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch, HBASE-5441.D1857.4.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "dhruba borthakur (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218971#comment-13218971 ] 

dhruba borthakur commented on HBASE-5441:
-----------------------------------------

This patch looks good and has been running in our clusters for about a week. Code looks good +1.
                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch, HBASE-5441.D1857.4.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219823#comment-13219823 ] 

Hudson commented on HBASE-5441:
-------------------------------

Integrated in HBase-TRUNK-security #125 (See [https://builds.apache.org/job/HBase-TRUNK-security/125/])
    HBASE-5441 HRegionThriftServer may not start because of a race-condition (Scott Chen) (Revision 1295192)

     Result = FAILURE
tedyu : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java

                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: 5441-v5.txt, HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch, HBASE-5441.D1857.4.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213980#comment-13213980 ] 

Hadoop QA commented on HBASE-5441:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12515639/HBASE-5441.D1857.4.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated -136 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 151 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.replication.TestReplication
                  org.apache.hadoop.hbase.mapreduce.TestImportTsv
                  org.apache.hadoop.hbase.mapred.TestTableMapReduce
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1013//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1013//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1013//console

This message is automatically generated.
                
> HRegionThriftServer may not start because of a race-condition
> -------------------------------------------------------------
>
>                 Key: HBASE-5441
>                 URL: https://issues.apache.org/jira/browse/HBASE-5441
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5441.D1845.1.patch, HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch, HBASE-5441.D1857.4.patch
>
>
> This happens because the master is not started when ThriftServerRunner tries to create an HBaseAdmin.
> org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet
>         at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333)
>         at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150)
>         at $Proxy8.getProtocolVersion(Unknown Source)
>         at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280)
>         at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332)
>         at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649)
>         at org.apache.hadoop.hbase.client.HBaseAdmin.<init>(HBaseAdmin.java:108)
>         at org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.<init>(ThriftServerRunner.java:516)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.<init>(HRegionThriftServer.java:104)
>         at org.apache.hadoop.hbase.regionserver.HRegionThriftServer.<init>(HRegionThriftServer.java:74)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658)
>         at java.lang.Thread.run(Thread.java:662)
> 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira