You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "hongwei1203 (via GitHub)" <gi...@apache.org> on 2025/12/29 08:34:16 UTC
[PR] GUACAMOLE-2194: Update Chinese translations [guacamole-client]
hongwei1203 opened a new pull request, #1142:
URL: https://github.com/apache/guacamole-client/pull/1142
GUACAMOLE-2194: Update Chinese translations and sort JSON keys alphabetically. Continue #1141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2194: Update Chinese translations [guacamole-client]
Posted by "hongwei1203 (via GitHub)" <gi...@apache.org>.
hongwei1203 commented on PR #1142:
URL: https://github.com/apache/guacamole-client/pull/1142#issuecomment-3696836404
> @hongwei1203 The changes look good, but your pull requests still need to have `GUACAMOLE-2194: ` prepended to them - for example, `GUACAMOLE-2194: Add spaces to maintain alignment.`
Sorry about that. It’s fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2194: Update Chinese translations [guacamole-client]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #1142:
URL: https://github.com/apache/guacamole-client/pull/1142#issuecomment-3696684060
@hongwei1203 The changes look good, but your pull requests still need to have `GUACAMOLE-2194: ` prepended to them - for example, `GUACAMOLE-2194: Add spaces to maintain alignment.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2194: Update Chinese translations [guacamole-client]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on code in PR #1142:
URL: https://github.com/apache/guacamole-client/pull/1142#discussion_r2651002692
##########
guacamole/src/main/frontend/src/translations/zh.json:
##########
@@ -474,10 +485,18 @@
"PLAYER" : {
"ACTION_CANCEL" : "@:APP.ACTION_CANCEL",
+ "ACTION_CLOSE" : "关闭",
Review Comment:
Please align the `:` with the lines above and below it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2194: Update Chinese translations [guacamole-client]
Posted by "hongwei1203 (via GitHub)" <gi...@apache.org>.
hongwei1203 commented on code in PR #1142:
URL: https://github.com/apache/guacamole-client/pull/1142#discussion_r2651064594
##########
guacamole/src/main/frontend/src/translations/zh.json:
##########
@@ -474,10 +485,18 @@
"PLAYER" : {
"ACTION_CANCEL" : "@:APP.ACTION_CANCEL",
+ "ACTION_CLOSE" : "关闭",
Review Comment:
Finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2194: Update Chinese translations [guacamole-client]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman merged PR #1142:
URL: https://github.com/apache/guacamole-client/pull/1142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org