[GitHub] deltaspike pull request #55: squid:S2583 - Conditions should not uncondition...

[johnament <gi...@git.apache.org>]

Github user johnament commented on a diff in the pull request:

    https://github.com/apache/deltaspike/pull/55#discussion_r69667867
  
    --- Diff: deltaspike/modules/data/impl/src/main/java/org/apache/deltaspike/data/impl/handler/QueryHandler.java ---
    @@ -154,10 +154,6 @@ public Object process(Object proxy, Method method, Object[] args) throws Throwab
             catch (Exception e)
             {
                 log.log(Level.FINEST, "Query execution error", e);
    -            if (queryContext != null)
    --- End diff --
    
    Everything else in this PR looks fine except this change.  There is a chance that queryContext may be null here, its just not reported due to runtime exceptions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---