[jira] [Commented] (AIRFLOW-4488) 'max_active_dag_runs_per_dag' typo in 1.10-stable branch

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16992780#comment-16992780 ] 

ASF GitHub Bot commented on AIRFLOW-4488:
-----------------------------------------

eladkal commented on pull request #6778: [AIRFLOW-4488] fix typo for non-RBAC UI in max_active_runs_per_dag
URL: https://github.com/apache/airflow/pull/6778
 
 
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   https://issues.apache.org/jira/browse/AIRFLOW-4488
   
   ### Description
   https://github.com/apache/airflow/commit/86fdd145329bb0a474c6dab1a7557f11415f76ee  introduced the `max_active_runs_per_dag` setting
   https://github.com/apache/airflow/pull/3286 introduced the message on that setting but it had typo: `max_active_dag_runs_per_dag` when it should have been `max_active_runs_per_dag`
   
   The message exist only in non-RBAC UI in `v1-10` so this PR targets ` v1-10 test` branch
   
   ### Tests
   
   - Not needed
   
   ### Documentation
   
   - Not needed
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> 'max_active_dag_runs_per_dag' typo in 1.10-stable branch
> --------------------------------------------------------
>
>                 Key: AIRFLOW-4488
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4488
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: ui
>    Affects Versions: 1.10.3
>            Reporter: t oo
>            Priority: Minor
>
> Note: this issue only affects v1-10 (stable and test) branch NOT master branch (as master has been refactored)
> 'max_active_dag_runs_per_dag' is printed on the ui but this is not a valid variable. The valid variable name is 'max_active_runs_per_dag' as per __init__.py and default_airflow.cfg
> Line with the issue:
> https://github.com/apache/airflow/blob/v1-10-test/airflow/www/views.py#L944
> *actual:*
> <code>max_active_dag_runs_per_dag</code>
> *expected:*
> <code>max_active_runs_per_dag</code>



--
This message was sent by Atlassian Jira
(v8.3.4#803005)