[jira] Commented: (TOMAHAWK-1072) MyFacesExtensionsFilter overfills memory

["Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/TOMAHAWK-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716848#action_12716848 ] 

Leonardo Uribe commented on TOMAHAWK-1072:
------------------------------------------

An inspection of the code reveals that there is not problem with extensions filter.

On the first part of method doFilter:

    public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException {

        if(request.getAttribute(DOFILTER_CALLED)!=null)
        {
            chain.doFilter(request, response);
            return;
        }

        request.setAttribute(DOFILTER_CALLED,"true");

A param is set on request scope to prevent call its methods more than once, so there is no reason why ExtensionsFilter could overfills memory.

This one will be closed as invalid (can't be solved on myfaces land).



> MyFacesExtensionsFilter overfills memory
> ----------------------------------------
>
>                 Key: TOMAHAWK-1072
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1072
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: File Upload
>    Affects Versions: 1.1.6
>         Environment: ajax4jsf-1.1.2-20070802.000138-143
> richfaces-3.0.1-SNAPSHOT
> tomahawk-1.1.6
> tomcat 5.5.20
>            Reporter: Areshchenko Alexandr
>
> when i include MyFacesExtensionsFilter into web.xml like this
> <filter>
>   <filter-name>MyFacesExtensionsFilter</filter-name>
>   <filter-class>org.apache.myfaces.webapp.filter.ExtensionsFilter</filter-class>
>   
>   <init-param>
>    <param-name>uploadMaxFileSize</param-name>
>    <param-value>10m</param-value>
>   </init-param>
>   <init-param>
>    <param-name>uploadThresholdSize</param-name>
>    <param-value>2m</param-value>
>   </init-param>
>  </filter>
>   <filter-mapping>
>   <filter-name>MyFacesExtensionsFilter</filter-name>
>   <servlet-name>Faces Servlet</servlet-name>
>  </filter-mapping>
>  <!-- extension mapping for serving page-independent resources (javascript, stylesheets, images, etc.)  -->
>    <filter-mapping>
>   <filter-name>MyFacesExtensionsFilter</filter-name>
>   <url-pattern>/*</url-pattern>
>  </filter-mapping>
> then after clicking any button or link cases exceptions
> javax.servlet.ServletException: Servlet execution threw an exception
> 	org.ajax4jsf.framework.ajax.xmlfilter.BaseXMLFilter.doXmlFilter(BaseXMLFilter.java:139)
> 	org.ajax4jsf.framework.ajax.xmlfilter.BaseFilter.doFilter(BaseFilter.java:276)
> 	org.apache.myfaces.webapp.filter.ExtensionsFilter.doFilter(ExtensionsFilter.java:100)
> 	org.apache.myfaces.webapp.filter.ExtensionsFilter.doFilter(ExtensionsFilter.java:147)
> java.lang.OutOfMemoryError: Java heap space
> 19:06:03,546 ERROR [Faces Servlet]:253 - Servlet.service() for servlet Faces Servlet threw exception
> java.lang.OutOfMemoryError: Java heap space

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.