You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by an...@apache.org on 2014/10/14 10:02:40 UTC

svn commit: r1631661 - in /tomee/tomee/trunk/container/openejb-loader/src/main/java/org/apache/openejb: loader/BasicURLClassPath.java observer/ObserverManager.java

Author: andygumbrecht
Date: Tue Oct 14 08:02:40 2014
New Revision: 1631661

URL: http://svn.apache.org/r1631661
Log:
pmd

Modified:
    tomee/tomee/trunk/container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java
    tomee/tomee/trunk/container/openejb-loader/src/main/java/org/apache/openejb/observer/ObserverManager.java

Modified: tomee/tomee/trunk/container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java?rev=1631661&r1=1631660&r2=1631661&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java (original)
+++ tomee/tomee/trunk/container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java Tue Oct 14 08:02:40 2014
@@ -95,7 +95,7 @@ public abstract class BasicURLClassPath 
     }
 
     protected Object getURLClassPath(final URLClassLoader loader) throws Exception {
-        return getUcpField().get(loader);
+        return this.getUcpField().get(loader);
     }
 
     private Field getUcpField() throws Exception {
@@ -103,14 +103,14 @@ public abstract class BasicURLClassPath 
             ucpField = AccessController.doPrivileged(new PrivilegedAction<Field>() {
                 @Override
                 public Field run() {
-                    Field ucp = null;
                     try {
-                        ucp = URLClassLoader.class.getDeclaredField("ucp");
+                        final Field ucp = URLClassLoader.class.getDeclaredField("ucp");
                         ucp.setAccessible(true);
+                        return ucp;
                     } catch (final Exception e2) {
                         e2.printStackTrace();
                     }
-                    return ucp;
+                    return null;
                 }
             });
         }

Modified: tomee/tomee/trunk/container/openejb-loader/src/main/java/org/apache/openejb/observer/ObserverManager.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-loader/src/main/java/org/apache/openejb/observer/ObserverManager.java?rev=1631661&r1=1631660&r2=1631661&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-loader/src/main/java/org/apache/openejb/observer/ObserverManager.java (original)
+++ tomee/tomee/trunk/container/openejb-loader/src/main/java/org/apache/openejb/observer/ObserverManager.java Tue Oct 14 08:02:40 2014
@@ -409,9 +409,9 @@ public class ObserverManager {
                 }
 
                 if (t instanceof InvocationTargetException && t.getCause() != null) {
-                    logger().log(Level.SEVERE, "error invoking " + observer, t.getCause());
+                    ObserverManager.logger().log(Level.SEVERE, "error invoking " + observer, t.getCause());
                 } else {
-                    logger().log(Level.SEVERE, "error invoking " + observer, t);
+                    ObserverManager.logger().log(Level.SEVERE, "error invoking " + observer, t);
                 }
             } catch (final IllegalAccessException e) {
                 e.printStackTrace();