[GitHub] [bookkeeper] karanmehta93 commented on a change in pull request #2173: Call exceptionHandler if Bookie.start fails with exception.

[GitBox <gi...@apache.org>]

karanmehta93 commented on a change in pull request #2173: Call exceptionHandler if Bookie.start fails with exception.
URL: https://github.com/apache/bookkeeper/pull/2173#discussion_r333223978
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/server/service/BookieService.java
 ##########
 @@ -56,8 +59,14 @@ public BookieServer getServer() {
     protected void doStart() {
         try {
             this.server.start();
-        } catch (IOException | UnavailableException | InterruptedException | BKException e) {
-            throw new RuntimeException("Failed to start bookie server", e);
+        } catch (Throwable exc) {
+            LOG.error("Got unexpected exception while starting BookieServer", exc);
+            if (uncaughtExceptionHandler != null) {
+                LOG.error("Calling uncaughtExceptionHandler");
 
 Review comment:
   nit: add more details to this log line?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services