You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "taiyang-li (via GitHub)" <gi...@apache.org> on 2025/01/14 08:08:16 UTC

[I] [CH] support approx_count_distinct [incubator-gluten]

taiyang-li opened a new issue, #8528:
URL: https://github.com/apache/incubator-gluten/issues/8528

   ### Description
   
    support approx_count_distinct


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [I] [CH] support approx_count_distinct [incubator-gluten]

Posted by "taiyang-li (via GitHub)" <gi...@apache.org>.
taiyang-li closed issue #8528: [CH] support approx_count_distinct
URL: https://github.com/apache/incubator-gluten/issues/8528


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [I] [CH] support approx_count_distinct [incubator-gluten]

Posted by "taiyang-li (via GitHub)" <gi...@apache.org>.
taiyang-li commented on issue #8528:
URL: https://github.com/apache/incubator-gluten/issues/8528#issuecomment-2589275443

   velox implementation:https://github.com/apache/incubator-gluten/pull/1676/files 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [I] [CH] support approx_count_distinct [incubator-gluten]

Posted by "taiyang-li (via GitHub)" <gi...@apache.org>.
taiyang-li commented on issue #8528:
URL: https://github.com/apache/incubator-gluten/issues/8528#issuecomment-2594976625

   The performance of gluten has no significant advantage over vanilla. Need to improve it. 
   
   Gluten:
   ``` sql
   0: jdbc:hive2://localhost:10000/> select l_orderkey % 10, approx_count_distinct(l_partkey) from lineitem group by l_orderkey % 10 order by l_orderkey % 10 ;     
   +--------------------+-----------------------------------+
   | (l_orderkey % 10)  | approx_count_distinct(l_partkey)  |
   +--------------------+-----------------------------------+
   | 0                  | 18813                             |
   | 1                  | 20083                             |
   | 2                  | 18534                             |
   | 3                  | 18015                             |
   | 4                  | 19054                             |
   | 5                  | 19177                             |
   | 6                  | 19685                             |
   | 7                  | 18463                             |
   | 8                  | 19816                             |
   | 9                  | 18993                             |
   +--------------------+-----------------------------------+
   10 rows selected (2.203 seconds)
   ```
   
   Vanilla:
   ``` sql
   0: jdbc:hive2://localhost:10000/> select l_orderkey % 10, approx_count_distinct(l_partkey) from lineitem group by l_orderkey % 10 order by l_orderkey % 10 ; 
   +--------------------+-----------------------------------+
   | (l_orderkey % 10)  | approx_count_distinct(l_partkey)  |
   +--------------------+-----------------------------------+
   | 0                  | 18531                             |
   | 1                  | 18741                             |
   | 2                  | 18387                             |
   | 3                  | 18535                             |
   | 4                  | 18674                             |
   | 5                  | 18444                             |
   | 6                  | 18286                             |
   | 7                  | 18364                             |
   | 8                  | 18415                             |
   | 9                  | 19079                             |
   +--------------------+-----------------------------------+
   10 rows selected (2.383 seconds)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org