You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/08 08:07:46 UTC

[GitHub] [rocketmq] ShannonDing commented on a diff in pull request #4797: [ISSUE #4771]In HA mode, if you do not truncate consumerOffsetMap, it may cause a bug

ShannonDing commented on code in PR #4797:
URL: https://github.com/apache/rocketmq/pull/4797#discussion_r939947871


##########
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java:
##########
@@ -646,6 +648,11 @@ public void truncateDirtyFiles(long offsetToTruncate) {
 
         recoverTopicQueueTable();
 
+        // truncate consumer offset
+        truncateConsumerOffsetTable(this.offsetTable);

Review Comment:
   truncateConsumerOffsetTable() is OK, the parameter is not required.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org