You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Brust, Tim" <ti...@sinnerschrader.com> on 2020/11/16 15:39:49 UTC

Re: [External] Re: [VOTE] Geolocation Plugin Release

I vote +1:


  *   coho verify-archive passes
  *   coho verify-tags passes
  *   npm audit passes
  *   npm test passes
  *   re-reviewed changes, they make sense
--

Tim Brust, Product Engineer

tim.brust@sinnerschrader.com<ma...@sinnerschrader.com>

SinnerSchrader Deutschland GmbH | SinnerSchrader Group
Part of Accenture Interactive
Völckersstraße 38, 22765 Hamburg, Germany

Amtsgericht Hamburg HRB-Nr. 63663

Geschäftsführung: Dr. Axel Averdung (Sprecher),
Holger Blank, Kristina Bonitz, Philipp Kafkoulas, Florian Langmack, Sven Schmiede, Pia Schott u. a.

Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag

www.sinnerschrader.com | NEXT AGENCY

From: Niklas Merz <ni...@apache.org>
Date: Friday, 6. November 2020 at 08:41
To: dev@cordova.apache.org <de...@cordova.apache.org>
Subject: [External] Re: [VOTE] Geolocation Plugin Release
This message is from an EXTERNAL SENDER - be CAUTIOUS, particularly with links and attachments.

I vote +1

* valid hash and signature
* no audit issues
* check licenses + headers
* some local tests in emulators

November 6, 2020 5:58 AM, "Bryan Ellis" <er...@apache.org> wrote:

> Please review and vote on this Cordova Plugin Geolocation Release v4.1.0
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> The archive has been published to dist/dev:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__dist.apache.org_repos_dist_dev_cordova_geolocation-2D20201106&d=DwIFaQ&c=eIGjsITfXP_y-DLLX0uEHXJvU8nOHrUK8IrwNKOtkVU&r=cpdalg2AkAkNwsuGb83Rn1F0oaw9obXe_cnaIOV4Wow&m=mnO-f4aZDNn0iPHJ0XlNE4Jf7y1O3kqI7Mtetfo9_nc&s=qLT-kNRUyFA_9RnSL55SfTCIjXDA5yX_F4cZm0RrDKI&e=
>
> The package was published from its corresponding git tag:
> cordova-plugin-geolocation: 4.1.0 (a9c65b03b1)
>
> Upon a successful vote I will upload the archive to dist/, publish it to npm, and post the blog
> post.
>
> Voting guidelines: https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_cordova-2Dcoho_blob_master_docs_release-2Dvoting.md&d=DwIFaQ&c=eIGjsITfXP_y-DLLX0uEHXJvU8nOHrUK8IrwNKOtkVU&r=cpdalg2AkAkNwsuGb83Rn1F0oaw9obXe_cnaIOV4Wow&m=mnO-f4aZDNn0iPHJ0XlNE4Jf7y1O3kqI7Mtetfo9_nc&s=RGnKZ1FqpnEl3kxf2BmMEtAOP6Mul2U99sKx0e2sWo4&e=
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
>
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and sub-dependencies have Apache-compatible
> licenses
> * Ensured the npm audit report was sufficient for release
>
> * AS there are issues within the CI testing service accross ALL plugins, for this release I have
> manually tested:
> * Build Mobile Spec project for iOS & Android w/ CLI
> * Run Mobile Spec project on iOS & Android simulator w/ CLI
> * Executed the Mobile Spec Jasmine tests on iOS & Android
>
> Audit Report:
>
> 0 vulnerabilities found
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

________________________________

This message is for the designated recipient only and may contain privileged, proprietary, or otherwise private information. If you have received it in error, please notify the sender immediately and delete the original. Any other use of the email by you is prohibited.

Re: [VOTE] Geolocation Plugin Release

Posted by Bryan Ellis <er...@apache.org>.
The vote has now closed. The results are:

Positive Binding Votes: 4

* Bryan Ellis
* Niklas Merz
* Tim Brust
* Norman Breau

Negative Binding Votes: 0

The vote has passed.

Thanks everyone!


> On Nov 18, 2020, at 6:31, Norman Breau <no...@nbsolutions.ca> wrote:
> 
> I vote +1
> 
> * Confirmed archive
> * Confirmed tags
> * No flagged licenses.
> * audit licenses
> 
> On Nov 16 2020, at 11:39 am, Brust, Tim <ti...@sinnerschrader.com> wrote:
>> I vote +1:
>> 
>> 
>> * coho verify-archive passes
>> * coho verify-tags passes
>> * npm audit passes
>> * npm test passes
>> * re-reviewed changes, they make sense
>> --
>> 
>> Tim Brust, Product Engineer
>> tim.brust@sinnerschrader.com<ma...@sinnerschrader.com>
>> SinnerSchrader Deutschland GmbH | SinnerSchrader Group
>> Part of Accenture Interactive
>> Völckersstraße 38, 22765 Hamburg, Germany
>> 
>> Amtsgericht Hamburg HRB-Nr. 63663
>> Geschäftsführung: Dr. Axel Averdung (Sprecher),
>> Holger Blank, Kristina Bonitz, Philipp Kafkoulas, Florian Langmack, Sven Schmiede, Pia Schott u. a.
>> 
>> Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag
>> www.sinnerschrader.com | NEXT AGENCY
>> From: Niklas Merz <ni...@apache.org>
>> Date: Friday, 6. November 2020 at 08:41
>> To: dev@cordova.apache.org <de...@cordova.apache.org>
>> Subject: [External] Re: [VOTE] Geolocation Plugin Release
>> This message is from an EXTERNAL SENDER - be CAUTIOUS, particularly with links and attachments.
>> 
>> I vote +1
>> * valid hash and signature
>> * no audit issues
>> * check licenses + headers
>> * some local tests in emulators
>> 
>> November 6, 2020 5:58 AM, "Bryan Ellis" <er...@apache.org> wrote:
>>> Please review and vote on this Cordova Plugin Geolocation Release v4.1.0
>>> by replying to this email (and keep discussion on the DISCUSS thread)
>>> 
>>> The archive has been published to dist/dev:
>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__dist.apache.org_repos_dist_dev_cordova_geolocation-2D20201106&d=DwIFaQ&c=eIGjsITfXP_y-DLLX0uEHXJvU8nOHrUK8IrwNKOtkVU&r=cpdalg2AkAkNwsuGb83Rn1F0oaw9obXe_cnaIOV4Wow&m=mnO-f4aZDNn0iPHJ0XlNE4Jf7y1O3kqI7Mtetfo9_nc&s=qLT-kNRUyFA_9RnSL55SfTCIjXDA5yX_F4cZm0RrDKI&e=
>>> 
>>> The package was published from its corresponding git tag:
>>> cordova-plugin-geolocation: 4.1.0 (a9c65b03b1)
>>> 
>>> Upon a successful vote I will upload the archive to dist/, publish it to npm, and post the blog
>>> post.
>>> 
>>> Voting guidelines: https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_cordova-2Dcoho_blob_master_docs_release-2Dvoting.md&d=DwIFaQ&c=eIGjsITfXP_y-DLLX0uEHXJvU8nOHrUK8IrwNKOtkVU&r=cpdalg2AkAkNwsuGb83Rn1F0oaw9obXe_cnaIOV4Wow&m=mnO-f4aZDNn0iPHJ0XlNE4Jf7y1O3kqI7Mtetfo9_nc&s=RGnKZ1FqpnEl3kxf2BmMEtAOP6Mul2U99sKx0e2sWo4&e=
>>> 
>>> Voting will go on for a minimum of 48 hours.
>>> 
>>> I vote +1:
>>> 
>>> * Ran coho audit-license-headers over the relevant repos
>>> * Ran coho check-license to ensure all dependencies and sub-dependencies have Apache-compatible
>>> licenses
>>> * Ensured the npm audit report was sufficient for release
>>> 
>>> * AS there are issues within the CI testing service accross ALL plugins, for this release I have
>>> manually tested:
>>> * Build Mobile Spec project for iOS & Android w/ CLI
>>> * Run Mobile Spec project on iOS & Android simulator w/ CLI
>>> * Executed the Mobile Spec Jasmine tests on iOS & Android
>>> 
>>> Audit Report:
>>> 
>>> 0 vulnerabilities found
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>>> For additional commands, e-mail: dev-help@cordova.apache.org
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>> 
>> ________________________________
>> This message is for the designated recipient only and may contain privileged, proprietary, or otherwise private information. If you have received it in error, please notify the sender immediately and delete the original. Any other use of the email by you is prohibited.


Re: [External] Re: [VOTE] Geolocation Plugin Release

Posted by Norman Breau <no...@nbsolutions.ca>.
I vote +1

* Confirmed archive
* Confirmed tags
* No flagged licenses.
* audit licenses

On Nov 16 2020, at 11:39 am, Brust, Tim <ti...@sinnerschrader.com> wrote:
> I vote +1:
>
>
> * coho verify-archive passes
> * coho verify-tags passes
> * npm audit passes
> * npm test passes
> * re-reviewed changes, they make sense
> --
>
> Tim Brust, Product Engineer
> tim.brust@sinnerschrader.com<ma...@sinnerschrader.com>
> SinnerSchrader Deutschland GmbH | SinnerSchrader Group
> Part of Accenture Interactive
> Völckersstraße 38, 22765 Hamburg, Germany
>
> Amtsgericht Hamburg HRB-Nr. 63663
> Geschäftsführung: Dr. Axel Averdung (Sprecher),
> Holger Blank, Kristina Bonitz, Philipp Kafkoulas, Florian Langmack, Sven Schmiede, Pia Schott u. a.
>
> Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag
> www.sinnerschrader.com | NEXT AGENCY
> From: Niklas Merz <ni...@apache.org>
> Date: Friday, 6. November 2020 at 08:41
> To: dev@cordova.apache.org <de...@cordova.apache.org>
> Subject: [External] Re: [VOTE] Geolocation Plugin Release
> This message is from an EXTERNAL SENDER - be CAUTIOUS, particularly with links and attachments.
>
> I vote +1
> * valid hash and signature
> * no audit issues
> * check licenses + headers
> * some local tests in emulators
>
> November 6, 2020 5:58 AM, "Bryan Ellis" <er...@apache.org> wrote:
> > Please review and vote on this Cordova Plugin Geolocation Release v4.1.0
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > The archive has been published to dist/dev:
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__dist.apache.org_repos_dist_dev_cordova_geolocation-2D20201106&d=DwIFaQ&c=eIGjsITfXP_y-DLLX0uEHXJvU8nOHrUK8IrwNKOtkVU&r=cpdalg2AkAkNwsuGb83Rn1F0oaw9obXe_cnaIOV4Wow&m=mnO-f4aZDNn0iPHJ0XlNE4Jf7y1O3kqI7Mtetfo9_nc&s=qLT-kNRUyFA_9RnSL55SfTCIjXDA5yX_F4cZm0RrDKI&e=
> >
> > The package was published from its corresponding git tag:
> > cordova-plugin-geolocation: 4.1.0 (a9c65b03b1)
> >
> > Upon a successful vote I will upload the archive to dist/, publish it to npm, and post the blog
> > post.
> >
> > Voting guidelines: https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_cordova-2Dcoho_blob_master_docs_release-2Dvoting.md&d=DwIFaQ&c=eIGjsITfXP_y-DLLX0uEHXJvU8nOHrUK8IrwNKOtkVU&r=cpdalg2AkAkNwsuGb83Rn1F0oaw9obXe_cnaIOV4Wow&m=mnO-f4aZDNn0iPHJ0XlNE4Jf7y1O3kqI7Mtetfo9_nc&s=RGnKZ1FqpnEl3kxf2BmMEtAOP6Mul2U99sKx0e2sWo4&e=
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> >
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and sub-dependencies have Apache-compatible
> > licenses
> > * Ensured the npm audit report was sufficient for release
> >
> > * AS there are issues within the CI testing service accross ALL plugins, for this release I have
> > manually tested:
> > * Build Mobile Spec project for iOS & Android w/ CLI
> > * Run Mobile Spec project on iOS & Android simulator w/ CLI
> > * Executed the Mobile Spec Jasmine tests on iOS & Android
> >
> > Audit Report:
> >
> > 0 vulnerabilities found
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
> ________________________________
> This message is for the designated recipient only and may contain privileged, proprietary, or otherwise private information. If you have received it in error, please notify the sender immediately and delete the original. Any other use of the email by you is prohibited.