You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/11/22 08:48:42 UTC
[kudu-CR] [consensus] fix message on unprepared dedup messages
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11982
Change subject: [consensus] fix message on unprepared dedup messages
......................................................................
[consensus] fix message on unprepared dedup messages
A minor clean-up on RaftConsensus::UpdateReplica() aiming to fix
the warning message on the unprepared messages from deduplicated
request.
Change-Id: Ib9871068743b27720f839797ba6aa6f23cf03a7a
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 20 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/11982/1
--
To view, visit http://gerrit.cloudera.org:8080/11982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9871068743b27720f839797ba6aa6f23cf03a7a
Gerrit-Change-Number: 11982
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [consensus] fix message on unprepared dedup ops
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11982
to look at the new patch set (#4).
Change subject: [consensus] fix message on unprepared dedup ops
......................................................................
[consensus] fix message on unprepared dedup ops
A minor clean-up on RaftConsensus::UpdateReplica() aiming to fix
the warning message on the unprepared operations from deduplicated
request.
Change-Id: Ib9871068743b27720f839797ba6aa6f23cf03a7a
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 21 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/11982/4
--
To view, visit http://gerrit.cloudera.org:8080/11982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9871068743b27720f839797ba6aa6f23cf03a7a
Gerrit-Change-Number: 11982
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [consensus] fix message on unprepared dedup messages
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11982
to look at the new patch set (#2).
Change subject: [consensus] fix message on unprepared dedup messages
......................................................................
[consensus] fix message on unprepared dedup messages
A minor clean-up on RaftConsensus::UpdateReplica() aiming to fix
the warning message on the unprepared messages from deduplicated
request.
Change-Id: Ib9871068743b27720f839797ba6aa6f23cf03a7a
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 20 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/11982/2
--
To view, visit http://gerrit.cloudera.org:8080/11982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9871068743b27720f839797ba6aa6f23cf03a7a
Gerrit-Change-Number: 11982
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [consensus] fix message on unprepared dedup ops
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11982 )
Change subject: [consensus] fix message on unprepared dedup ops
......................................................................
[consensus] fix message on unprepared dedup ops
A minor clean-up on RaftConsensus::UpdateReplica() aiming to fix
the warning message on the unprepared operations from deduplicated
request.
Change-Id: Ib9871068743b27720f839797ba6aa6f23cf03a7a
Reviewed-on: http://gerrit.cloudera.org:8080/11982
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 22 insertions(+), 28 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9871068743b27720f839797ba6aa6f23cf03a7a
Gerrit-Change-Number: 11982
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [consensus] fix message on unprepared dedup ops
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11982
to look at the new patch set (#5).
Change subject: [consensus] fix message on unprepared dedup ops
......................................................................
[consensus] fix message on unprepared dedup ops
A minor clean-up on RaftConsensus::UpdateReplica() aiming to fix
the warning message on the unprepared operations from deduplicated
request.
Change-Id: Ib9871068743b27720f839797ba6aa6f23cf03a7a
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 22 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/11982/5
--
To view, visit http://gerrit.cloudera.org:8080/11982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9871068743b27720f839797ba6aa6f23cf03a7a
Gerrit-Change-Number: 11982
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [consensus] fix message on unprepared dedup ops
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11982
to look at the new patch set (#3).
Change subject: [consensus] fix message on unprepared dedup ops
......................................................................
[consensus] fix message on unprepared dedup ops
A minor clean-up on RaftConsensus::UpdateReplica() aiming to fix
the warning message on the unprepared operations from deduplicated
request.
Change-Id: Ib9871068743b27720f839797ba6aa6f23cf03a7a
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 20 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/11982/3
--
To view, visit http://gerrit.cloudera.org:8080/11982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9871068743b27720f839797ba6aa6f23cf03a7a
Gerrit-Change-Number: 11982
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [consensus] fix message on unprepared dedup ops
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11982 )
Change subject: [consensus] fix message on unprepared dedup ops
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9871068743b27720f839797ba6aa6f23cf03a7a
Gerrit-Change-Number: 11982
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 26 Nov 2018 05:50:49 +0000
Gerrit-HasComments: No
[kudu-CR] [consensus] fix message on unprepared dedup ops
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11982 )
Change subject: [consensus] fix message on unprepared dedup ops
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11982/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11982/3//COMMIT_MSG@9
PS3, Line 9: to fix
: the warning message
> Hrm, by my understanding there is a difference: instead of claiming that de
Ah indeed, for some reason I'd assumed members of deduped_req.messages were being erased before entering the inner while loop.
--
To view, visit http://gerrit.cloudera.org:8080/11982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9871068743b27720f839797ba6aa6f23cf03a7a
Gerrit-Change-Number: 11982
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 26 Nov 2018 03:23:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] [consensus] fix message on unprepared dedup ops
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11982 )
Change subject: [consensus] fix message on unprepared dedup ops
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11982/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11982/3//COMMIT_MSG@9
PS3, Line 9: to fix
: the warning message
Hrm, maybe I'm not seeing it. Is this just a cleanup or is it actually fixing something? The change seems functionally equivalent.
http://gerrit.cloudera.org:8080/#/c/11982/3/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:
http://gerrit.cloudera.org:8080/#/c/11982/3/src/kudu/consensus/raft_consensus.cc@1500
PS3, Line 1500: << "Could not prepare transaction for op " << (*iter)->get()->id()
: << " and following " << std::distance(iter, messages.end()) - 1
: << " ops. Status for this op: " << prepare_status.ToString();
nit: use Substitute?
--
To view, visit http://gerrit.cloudera.org:8080/11982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9871068743b27720f839797ba6aa6f23cf03a7a
Gerrit-Change-Number: 11982
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sun, 25 Nov 2018 19:40:18 +0000
Gerrit-HasComments: Yes
[kudu-CR] [consensus] fix message on unprepared dedup ops
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11982 )
Change subject: [consensus] fix message on unprepared dedup ops
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11982/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11982/3//COMMIT_MSG@9
PS3, Line 9: to fix
: the warning message
> Hrm, maybe I'm not seeing it. Is this just a cleanup or is it actually fixi
Hrm, by my understanding there is a difference: instead of claiming that deduped_req.messages.size() are not prepared, actual number is what's left after the 'iter', i.e. std::distance(iter, messages.end()) - 1.
http://gerrit.cloudera.org:8080/#/c/11982/3/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:
http://gerrit.cloudera.org:8080/#/c/11982/3/src/kudu/consensus/raft_consensus.cc@1500
PS3, Line 1500: << "Could not prepare transaction for op " << (*iter)->get()->id()
: << " and following " << std::distance(iter, messages.end()) - 1
: << " ops. Status for this op: " << prepare_status.ToString();
> nit: use Substitute?
Done
--
To view, visit http://gerrit.cloudera.org:8080/11982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9871068743b27720f839797ba6aa6f23cf03a7a
Gerrit-Change-Number: 11982
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 26 Nov 2018 03:06:33 +0000
Gerrit-HasComments: Yes