You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Saurabh Katiyal (Code Review)" <ge...@cloudera.org> on 2024/02/22 11:36:43 UTC
[Impala-ASF-CR] IMPALA-12830: test webserver hide logs link() could fail in the exhaustive build
Saurabh Katiyal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21053
Change subject: IMPALA-12830: test_webserver_hide_logs_link() could fail in the exhaustive build
......................................................................
IMPALA-12830: test_webserver_hide_logs_link() could fail in the exhaustive build
fixed order of "/hadoop-varz" test_web_pages.py for test "test_webserver_hide_logs_link()".
In this test for links "/hadoop-varz" was added to expected_catalog_links[]
as part of improvement IMPALA-9086 but order was conflicted with "/events"
Change-Id: I042ae0464cfc3d13b74ff28099ad52ff53e19f74
---
M tests/custom_cluster/test_web_pages.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/21053/1
--
To view, visit http://gerrit.cloudera.org:8080/21053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I042ae0464cfc3d13b74ff28099ad52ff53e19f74
Gerrit-Change-Number: 21053
Gerrit-PatchSet: 1
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
[Impala-ASF-CR] IMPALA-12830: test webserver hide logs link() could fail in the exhaustive build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21053 )
Change subject: IMPALA-12830: test_webserver_hide_logs_link() could fail in the exhaustive build
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I042ae0464cfc3d13b74ff28099ad52ff53e19f74
Gerrit-Change-Number: 21053
Gerrit-PatchSet: 2
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Feb 2024 21:12:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12830: test webserver hide logs link() could fail in the exhaustive build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21053 )
Change subject: IMPALA-12830: test_webserver_hide_logs_link() could fail in the exhaustive build
......................................................................
IMPALA-12830: test_webserver_hide_logs_link() could fail in the exhaustive build
fixed order of "/hadoop-varz" test_web_pages.py for test "test_webserver_hide_logs_link()".
In this test for links "/hadoop-varz" was added to expected_catalog_links[]
as part of improvement IMPALA-9086 but order was conflicted with "/events"
Change-Id: I042ae0464cfc3d13b74ff28099ad52ff53e19f74
Reviewed-on: http://gerrit.cloudera.org:8080/21053
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_web_pages.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I042ae0464cfc3d13b74ff28099ad52ff53e19f74
Gerrit-Change-Number: 21053
Gerrit-PatchSet: 3
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-12830: test webserver hide logs link() could fail in the exhaustive build
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21053 )
Change subject: IMPALA-12830: test_webserver_hide_logs_link() could fail in the exhaustive build
......................................................................
Patch Set 1: Code-Review+2
Tested this myself and it pass.
impala-py.test --exploration=exhaustive -k test_webserver_hide_logs_link custom_cluster/test_web_pages.py
--
To view, visit http://gerrit.cloudera.org:8080/21053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I042ae0464cfc3d13b74ff28099ad52ff53e19f74
Gerrit-Change-Number: 21053
Gerrit-PatchSet: 1
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Feb 2024 16:36:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12830: test webserver hide logs link() could fail in the exhaustive build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21053 )
Change subject: IMPALA-12830: test_webserver_hide_logs_link() could fail in the exhaustive build
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/15276/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I042ae0464cfc3d13b74ff28099ad52ff53e19f74
Gerrit-Change-Number: 21053
Gerrit-PatchSet: 1
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Feb 2024 12:02:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12830: test webserver hide logs link() could fail in the exhaustive build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21053 )
Change subject: IMPALA-12830: test_webserver_hide_logs_link() could fail in the exhaustive build
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I042ae0464cfc3d13b74ff28099ad52ff53e19f74
Gerrit-Change-Number: 21053
Gerrit-PatchSet: 2
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Feb 2024 16:37:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12830: test webserver hide logs link() could fail in the exhaustive build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21053 )
Change subject: IMPALA-12830: test_webserver_hide_logs_link() could fail in the exhaustive build
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10320/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I042ae0464cfc3d13b74ff28099ad52ff53e19f74
Gerrit-Change-Number: 21053
Gerrit-PatchSet: 2
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Feb 2024 16:37:16 +0000
Gerrit-HasComments: No