[GitHub] [helix] narendly commented on issue #1198: Duplicate classes in exported jars

[GitBox <gi...@apache.org>]

narendly commented on issue #1198:
URL: https://github.com/apache/helix/issues/1198#issuecomment-667558303


   > There are duplicate classes at runtime since 1.0+, because of multiple modules packaging. Two different JARs contain the same package but with different contents. Eg, both helix-core.jar and metrics-common.jar contains `SensorNameProvider.class`. And at tests runtime, we have a check to detect duplicate classes and this causes tests failure.
   > 
   > The problem is, when we package the helix jars, the dependent subproject's classes are packaged into helix-core.jar: all classes in module helix-core and its dependencies match `org.apache.helix.*` are packaged to helix-core.jar. Then there are duplicate classes from metrics-common.jar/zookeeper-api.jar/helix-core.jar
   > 
   > Though helix doesn't have duplicate classes in the same package, it is still not a good practice to package the same class into two different jars that have dependency relation.
   > 
   
   I'm not understanding what kind of test failures we are seeing. Could you post what failures we are seeing here?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org