You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by gi...@apache.org on 2026/09/24 16:22:35 UTC

(datafusion) 01/01: chore: Use preinstalled clang for wasm CI job (#25649)

This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-25649-23f6f94c308a800748a5f8b7a5b85d5e41e5dc95
in repository https://gitbox.apache.org/repos/asf/datafusion.git

commit 2500a0d0a76f1ad116fb4abc8bf821f825d74d14
Author: Neil Conway <ne...@gmail.com>
AuthorDate: Thu Sep 24 16:22:23 2026 +0000

    chore: Use preinstalled clang for wasm CI job (#25649)
    
    ## Which issue does this PR close?
    
    - N/A
    
    ## Rationale for this change
    
    In the last few weeks, there were 73 instances of PRs being removed from
    the merge queue. ~90% of those removals were due to timeouts or other
    transient infrastructure issues. Of those, 9 removals came from failures
    attempting to update the `apt` cache as part of installing `clang`.
    
    Updating `apt` is actually not necessary: the result is installing clang
    18, which is already preinstalled on the runners anyway. This PR changes
    the wasm CI job to just use `clang-18` and check it is present, rather
    than using whatever version is supplied by `apt`.
    
    The tradeoff is that `clang` upgrades need to be done explicitly,
    although perhaps there is some merit to that from a reproducibility
    perspective as well.
    
    ## What changes are included in this PR?
    
    See above, CI change only.
    
    ## What is the testing strategy for this PR?
    
    CI will (hopefully) pass.
    
    ## Are there any user-facing changes?
    
    No.
---
 .github/workflows/rust.yml | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index b6c9114942..d9f327b401 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -583,16 +583,20 @@ jobs:
     name: build and run with wasm-pack
     if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'apache/datafusion') }}
     runs-on: ubuntu-24.04
+    env:
+      # Use the preinstalled Clang 18 even if the runner's default Clang changes.
+      CC_wasm32_unknown_unknown: clang-18
+      CXX_wasm32_unknown_unknown: clang++-18
     steps:
       - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1  # v7.0.1
       - parallel:
           - name: Setup for wasm32
             run: |
               rustup target add wasm32-unknown-unknown
-          - name: Install dependencies
+          - name: Check preinstalled Clang
             run: |
-              sudo apt-get update -qq
-              sudo apt-get install -y -qq clang
+              clang-18 --version
+              clang++-18 --version
           - name: Setup wasm-pack
             uses: taiki-e/install-action@9114bf4d891761788c546334fd37538eae1bf8b3  # v2.87.16
             with:


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org