[GitHub] [ozone] siddhantsangwan commented on a change in pull request #2695: HDDS-5797. Support setting Datanode Reserved Space in MiniOzoneCluster.

[GitBox <gi...@apache.org>]

siddhantsangwan commented on a change in pull request #2695:
URL: https://github.com/apache/ozone/pull/2695#discussion_r719624864



##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneClusterImpl.java
##########
@@ -818,6 +818,9 @@ protected String getSCMAddresses(List<StorageContainerManager> scms) {
           Path dir = Paths.get(datanodeBaseDir, "data-" + j, "containers");
           Files.createDirectories(dir);
           dataDirs.add(dir.toString());
+          datanodeReservedSpace.ifPresent(
+              s -> dnConf.set(ScmConfigKeys.HDDS_DATANODE_DIR_DU_RESERVED,
+                  dir + ":" + s));

Review comment:
       For the unit test: Is there a better way than adding a `reservedInBytes` getter to `VolumeInfo` for testing, and then asserting its value for each volume?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org