You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "sreeharshar84 (via GitHub)" <gi...@apache.org> on 2024/12/10 18:50:19 UTC
[PR] CALCITE-6726: Add translation for MOD operator in MSSQL [calcite]
sreeharshar84 opened a new pull request, #4084:
URL: https://github.com/apache/calcite/pull/4084
MOD is not supported in MSSQL. Translate it to %.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CALCITE-6726: Add translation for MOD operator in MSSQL [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #4084:
URL: https://github.com/apache/calcite/pull/4084#issuecomment-2536600468
Closing in favor #4087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CALCITE-6726: Add translation for MOD operator in MSSQL [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #4084:
URL: https://github.com/apache/calcite/pull/4084#issuecomment-2532941284
this is a small change, so if you can apply it on top of main it's best.
in general, you should use rebase and not merge when resolving conflicts, then this won't happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CALCITE-6726: Add translation for MOD operator in MSSQL [calcite]
Posted by "sreeharshar84 (via GitHub)" <gi...@apache.org>.
sreeharshar84 commented on PR #4084:
URL: https://github.com/apache/calcite/pull/4084#issuecomment-2535952203
> MOD is not supported in MSSQL. Translate it to %.
I have created a new PR https://github.com/apache/calcite/pull/4087 to avoid the problems with the merge/rebase. The changes are exactly the same. @mihaibudiu Please approve the new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CALCITE-6726: Add translation for MOD operator in MSSQL [calcite]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4084:
URL: https://github.com/apache/calcite/pull/4084#issuecomment-2532986573
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4084) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4084&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4084&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4084&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4084&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4084&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4084)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CALCITE-6726: Add translation for MOD operator in MSSQL [calcite]
Posted by "sreeharshar84 (via GitHub)" <gi...@apache.org>.
sreeharshar84 commented on PR #4084:
URL: https://github.com/apache/calcite/pull/4084#issuecomment-2532937400
> you may want to squash the commits to a single one.
I'm unable to squash the changes because one of them is a merge (rebase). Do you think I should create a new PR with changes on a new branch/fork?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CALCITE-6726: Add translation for MOD operator in MSSQL [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu closed pull request #4084: CALCITE-6726: Add translation for MOD operator in MSSQL
URL: https://github.com/apache/calcite/pull/4084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CALCITE-6726: Add translation for MOD operator in MSSQL [calcite]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4084:
URL: https://github.com/apache/calcite/pull/4084#issuecomment-2532979581
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4084) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4084&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4084&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4084&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4084&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4084&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4084)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org