You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jesse Yates (JIRA)" <ji...@apache.org> on 2012/08/13 23:20:38 UTC
[jira] [Created] (HBASE-6568) Extract daemon thread factory from
HTable
Jesse Yates created HBASE-6568:
----------------------------------
Summary: Extract daemon thread factory from HTable
Key: HBASE-6568
URL: https://issues.apache.org/jira/browse/HBASE-6568
Project: HBase
Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Jesse Yates
Fix For: 0.96.0
The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6568) Extract daemon thread factory from
HTable into its own class
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435358#comment-13435358 ]
Zhihong Ted Yu commented on HBASE-6568:
---------------------------------------
Currently we have:
{code}
./hbase-server/src/main/java/org/apache/hadoop/hbase/util/BloomFilterFactory.java
./hbase-server/src/main/java/org/apache/hadoop/hbase/util/ChecksumFactory.java
./hbase-server/src/main/java/org/apache/hadoop/hbase/util/RetryCounterFactory.java
{code}
Maybe move DaemonThreadFactory.java there ?
> Extract daemon thread factory from HTable into its own class
> ------------------------------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6568-addendum.patch, java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6568) Extract daemon thread factory from
HTable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433876#comment-13433876 ]
Hadoop QA commented on HBASE-6568:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12540764/java_HBASE-6568-v0.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
org.apache.hadoop.hbase.catalog.TestMetaReaderEditor
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2559//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2559//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2559//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2559//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2559//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2559//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2559//console
This message is automatically generated.
> Extract daemon thread factory from HTable
> -----------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6568) Extract daemon thread factory from
HTable
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-6568:
-------------------------------
Attachment: java_HBASE-6568-v0.patch
Attaching patch, posting to RB momentarily.
> Extract daemon thread factory from HTable
> -----------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6568) Extract daemon thread factory from
HTable
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-6568:
-------------------------------
Issue Type: Sub-task (was: Bug)
Parent: HBASE-6055
> Extract daemon thread factory from HTable
> -----------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Fix For: 0.96.0
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6568) Extract daemon thread factory from
HTable into its own class
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6568:
----------------------------------
Summary: Extract daemon thread factory from HTable into its own class (was: Extract daemon thread factory from HTable)
> Extract daemon thread factory from HTable into its own class
> ------------------------------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6568) Extract daemon thread factory from
HTable into its own class
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436882#comment-13436882 ]
stack commented on HBASE-6568:
------------------------------
bq. Sounds like we should do the backport of the current patch to 0.94, but into the util package.
Yes. Maybe do new issue for that rather than addendum it.
bq. Then we do another patch to move the current (0.96) into Threads and that up into hbase-commons. Thoughts?
Yes
Thanks Jesse.
> Extract daemon thread factory from HTable into its own class
> ------------------------------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6568-addendum.patch, java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6568) Extract daemon thread factory from
HTable into its own class
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435361#comment-13435361 ]
Jesse Yates commented on HBASE-6568:
------------------------------------
I'd argue those things should move out to commons, not this down. Its a generally useful utility (not sure about how generally useful those are) so the common package seems like a reasonable place; I could see hbase-common being the hbase-useful-java-stuff jar (akin to guava).
> Extract daemon thread factory from HTable into its own class
> ------------------------------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6568-addendum.patch, java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6568) Extract daemon thread factory from
HTable
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434241#comment-13434241 ]
Andrew Purtell commented on HBASE-6568:
---------------------------------------
+1
> Extract daemon thread factory from HTable
> -----------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6568) Extract daemon thread factory from
HTable into its own class
Posted by "Himanshu Vashishtha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435306#comment-13435306 ]
Himanshu Vashishtha commented on HBASE-6568:
--------------------------------------------
Should this be backported to .94 too?
> Extract daemon thread factory from HTable into its own class
> ------------------------------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6568) Extract daemon thread factory from
HTable into its own class
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435313#comment-13435313 ]
Jesse Yates commented on HBASE-6568:
------------------------------------
Though I just talked to Lars, and he changed my mind - yeah this is probably fine to backport, especially since its useful for some of the replication stuff.
> Extract daemon thread factory from HTable into its own class
> ------------------------------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6568) Extract daemon thread factory from
HTable into its own class
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434564#comment-13434564 ]
Hudson commented on HBASE-6568:
-------------------------------
Integrated in HBase-TRUNK #3215 (See [https://builds.apache.org/job/HBase-TRUNK/3215/])
HBASE-6568 Extract daemon thread factory from HTable into its own class (Jesse Yates) (Revision 1372963)
Result = SUCCESS
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/DaemonThreadFactory.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
> Extract daemon thread factory from HTable into its own class
> ------------------------------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-6568) Extract daemon thread factory from
HTable
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates reassigned HBASE-6568:
----------------------------------
Assignee: Jesse Yates
> Extract daemon thread factory from HTable
> -----------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6568) Extract daemon thread factory from
HTable
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433559#comment-13433559 ]
Jesse Yates commented on HBASE-6568:
------------------------------------
Patch coming momentarily...
> Extract daemon thread factory from HTable
> -----------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Fix For: 0.96.0
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6568) Extract daemon thread factory from
HTable into its own class
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-6568:
-------------------------------
Resolution: Fixed
Release Note: Adding DaemonThreadFactory (extracted from HTable) - a thread factory that creates properly named, daemon threads.
Status: Resolved (was: Patch Available)
Closing. Remaining work is in HBASE-6637.
> Extract daemon thread factory from HTable into its own class
> ------------------------------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6568-addendum.patch, java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6568) Extract daemon thread factory from
HTable into its own class
Posted by "Himanshu Vashishtha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435724#comment-13435724 ]
Himanshu Vashishtha commented on HBASE-6568:
--------------------------------------------
Ok, waiting for the 0.94 backport.
> Extract daemon thread factory from HTable into its own class
> ------------------------------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6568-addendum.patch, java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6568) Extract daemon thread factory from
HTable into its own class
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434670#comment-13434670 ]
Hudson commented on HBASE-6568:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #130 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/130/])
HBASE-6568 Extract daemon thread factory from HTable into its own class (Jesse Yates) (Revision 1372963)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/DaemonThreadFactory.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
> Extract daemon thread factory from HTable into its own class
> ------------------------------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6568) Extract daemon thread factory from
HTable into its own class
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434255#comment-13434255 ]
Zhihong Ted Yu commented on HBASE-6568:
---------------------------------------
Integrated to trunk.
Thanks for the patch, Jesse.
Thanks for the review, Andy.
> Extract daemon thread factory from HTable into its own class
> ------------------------------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6568) Extract daemon thread factory from
HTable into its own class
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435368#comment-13435368 ]
Hadoop QA commented on HBASE-6568:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12541090/hbase-6568-addendum.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2590//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2590//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2590//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2590//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2590//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2590//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2590//console
This message is automatically generated.
> Extract daemon thread factory from HTable into its own class
> ------------------------------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6568-addendum.patch, java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6568) Extract daemon thread factory from
HTable into its own class
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436868#comment-13436868 ]
stack commented on HBASE-6568:
------------------------------
bq. How about we backport to 0.94 and close this and then do a new jira to move to common module and/or move package?
Yes.
It should be in util, not at top level. That should be fixed (the addendum applied?) Why not put it into our general Threads util class altogether? Thats where I'd look when looking for thready stuff -- it has method returning a factory currently).
It looks like the manufactored threads do not follow current thread naming conventions either where thread source is prefix on name, etc. (Why would you have -thread- in the name of a thread?)
I'd say revert this patch as is if only for fact that its not in util (it could be in client too if that is only user... later could be moved elsewhere if someone else wanted use it).
> Extract daemon thread factory from HTable into its own class
> ------------------------------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6568-addendum.patch, java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6568) Extract daemon thread factory from
HTable
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6568:
----------------------------------
Hadoop Flags: Reviewed
Status: Patch Available (was: Open)
> Extract daemon thread factory from HTable
> -----------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6568) Extract daemon thread factory from
HTable into its own class
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435311#comment-13435311 ]
Jesse Yates commented on HBASE-6568:
------------------------------------
@Himanshu its more of a feature add than anything - doesn't feel 0.94 worthy unless we want to do a 0.94-snapshot feature branch.
> Extract daemon thread factory from HTable into its own class
> ------------------------------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6568) Extract daemon thread factory from
HTable into its own class
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436389#comment-13436389 ]
Jonathan Hsieh commented on HBASE-6568:
---------------------------------------
I had a similar thought about moving it into the o.a.h.h.util or even new o.a.h.h.common package.
+1 from me either way.
How about we backport to 0.94 and close this and then do a new jira to move to common module and/or move package?
> Extract daemon thread factory from HTable into its own class
> ------------------------------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6568-addendum.patch, java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6568) Extract daemon thread factory from
HTable into its own class
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436878#comment-13436878 ]
Jesse Yates commented on HBASE-6568:
------------------------------------
bq. later could be moved elsewhere if someone else wanted use it
Using it for snapshots (the genesis of this patch) on the server side, so util/common is better than client.
bq. Why not put it into our general Threads util class altogether? Thats where I'd look when looking for thready stuff – it has method returning a factory currently.
Nice idea. It'd like to see Threads moved up to hbase-commons in that case though.
bq. It looks like the manufactored threads do not follow current thread naming conventions either where thread source is prefix on name, etc.
Just following the existing naming it was using.
Sounds like we should do the backport of the current patch to 0.94, but into the util package. Then we do another patch to move the current (0.96) into Threads and that up into hbase-commons. Thoughts?
> Extract daemon thread factory from HTable into its own class
> ------------------------------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6568-addendum.patch, java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6568) Extract daemon thread factory from
HTable into its own class
Posted by "Himanshu Vashishtha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436411#comment-13436411 ]
Himanshu Vashishtha commented on HBASE-6568:
--------------------------------------------
+1 to Jon's comment.
> Extract daemon thread factory from HTable into its own class
> ------------------------------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6568-addendum.patch, java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6568) Extract daemon thread factory from
HTable
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434245#comment-13434245 ]
Jesse Yates commented on HBASE-6568:
------------------------------------
Failed tests passed locally. Someone want to commit?
> Extract daemon thread factory from HTable
> -----------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6568) Extract daemon thread factory from
HTable into its own class
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-6568:
-------------------------------
Attachment: hbase-6568-addendum.patch
Realized that the DTF should actually live in hbase-commons (that's why we have it, right?). Attaching addendum to move it.
> Extract daemon thread factory from HTable into its own class
> ------------------------------------------------------------
>
> Key: HBASE-6568
> URL: https://issues.apache.org/jira/browse/HBASE-6568
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0
>
> Attachments: hbase-6568-addendum.patch, java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira