You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2014/06/17 16:46:29 UTC
Review Request 22684: Behavior change: host filtering no longer handles
startsWith matches
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22684/
-----------------------------------------------------------
Review request for Ambari and Alexandr Antonenko.
Bugs: ambari-6162
https://issues.apache.org/jira/browse/ambari-6162
Repository: ambari
Description
-------
If I have a host that has IP 10.0.2.15, in Ambari 1.6.0 if I start to filter by IP (by typing 10.0....), the hosts that match "startsWith" stay displayed.
In Ambari 1.6.1, now it only does exact match, so once I start typing, all hosts disappear until I finally type the whole thing in for exact match.
Hosts/ip.matches(10)
Diffs
-----
ambari-web/app/controllers/main/host.js 68b7ba2
ambari-web/app/utils/validator.js e59532f
ambari-web/test/controllers/main/host_test.js b491f3b
ambari-web/test/utils/validator_test.js 262c068
Diff: https://reviews.apache.org/r/22684/diff/
Testing
-------
Thanks,
Oleg Nechiporenko
Re: Review Request 22684: Behavior change: host filtering no longer handles
startsWith matches
Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22684/#review45940
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Antonenko
On June 17, 2014, 2:46 p.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22684/
> -----------------------------------------------------------
>
> (Updated June 17, 2014, 2:46 p.m.)
>
>
> Review request for Ambari and Alexandr Antonenko.
>
>
> Bugs: ambari-6162
> https://issues.apache.org/jira/browse/ambari-6162
>
>
> Repository: ambari
>
>
> Description
> -------
>
> If I have a host that has IP 10.0.2.15, in Ambari 1.6.0 if I start to filter by IP (by typing 10.0....), the hosts that match "startsWith" stay displayed.
>
> In Ambari 1.6.1, now it only does exact match, so once I start typing, all hosts disappear until I finally type the whole thing in for exact match.
>
> Hosts/ip.matches(10)
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/host.js 68b7ba2
> ambari-web/app/utils/validator.js e59532f
> ambari-web/test/controllers/main/host_test.js b491f3b
> ambari-web/test/utils/validator_test.js 262c068
>
> Diff: https://reviews.apache.org/r/22684/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>