You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/05/20 14:11:39 UTC

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1150: [CALCITE-2985] Implement JSON_STORAGE_SIZE function

zhztheplayer commented on a change in pull request #1150: [CALCITE-2985] Implement JSON_STORAGE_SIZE function
URL: https://github.com/apache/calcite/pull/1150#discussion_r285612993
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/runtime/JsonFunctions.java
 ##########
 @@ -631,6 +631,15 @@ public static String jsonRemove(JsonValueContext input, String... pathSpecs) {
     }
   }
 
+  public static Integer jsonStorageSize(Object input) {
 
 Review comment:
   Please check how we handle JSON input on other JSON functions such as `JSON_LENGH`, `JSON_DEPTH`, the way we handle them changed after applying CALCITE-3017 fix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services