You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by deepakddixit <gi...@git.apache.org> on 2017/05/12 08:51:44 UTC

[GitHub] geode pull request #511: Feature/geode 269

GitHub user deepakddixit opened a pull request:

    https://github.com/apache/geode/pull/511

    Feature/geode 269

    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    Yes. JIRA reference is GEODE-269.
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    Yes. 
    - [ ] Is your initial contribution a single, squashed commit?
    No. It is multiple commit, one actual code change and other is resolving conflict with latest develop
    - [ ] Does `gradlew build` run cleanly?
    Yes
    - [ ] Have you written or updated unit tests to verify your changes?
    Updated unit tests
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    Not adding dependencies.
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/deepakddixit/incubator-geode feature/GEODE-269

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/511.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #511
    
----
commit e2f337a23303822f8cd28bc887afca7203759673
Author: Deepak Dixit <de...@gmail.com>
Date:   2017-05-10T16:52:03Z

    GEODE-269 : Removing deprecated API's from FunctionService.

commit 929687e28335ee5ace679be5c540857080afd48f
Author: Deepak Dixit <de...@gmail.com>
Date:   2017-05-12T08:33:39Z

    GEODE-269 : Resolving conflicts with develop.

commit 3054de42d38aa8bfadd8912f0ab4dde259a701ef
Author: Deepak Dixit <de...@gmail.com>
Date:   2017-05-12T08:38:21Z

    GEODE-269 : Resolving conflicts with develop.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #511: Feature/geode 269

Posted by deepakddixit <gi...@git.apache.org>.

Github user deepakddixit commented on the issue:

    https://github.com/apache/geode/pull/511
  
    @jhuynh1 Sure will open new PR without conflict. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #511: Feature/geode 269

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/geode/pull/511


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #511: Feature/geode 269

Posted by jhuynh1 <gi...@git.apache.org>.

Github user jhuynh1 commented on the issue:

    https://github.com/apache/geode/pull/511
  
    Hi Deepak, 
    Sorry, I've tried merging this into develop but had issues with the conflicts and then was unable to credit you with the checkin.  Will you be able to recreate this pull request without the conflict?  I can always apply the origin patch otherwise, but I wanted to make sure you got attributed with the change.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #511: Feature/geode 269

Posted by jhuynh1 <gi...@git.apache.org>.

Github user jhuynh1 commented on the issue:

    https://github.com/apache/geode/pull/511
  
    I still get a conflicting file but it was simple enough to change.  It looks good to me.  I'll merge this in when I get a chance (tomorrow?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---