You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "xyuanlu (via GitHub)" <gi...@apache.org> on 2023/03/03 02:09:18 UTC
[GitHub] [helix] xyuanlu commented on a diff in pull request #2390: Add API for users to provide customized threadpool for different categories of state transition messages
xyuanlu commented on code in PR #2390:
URL: https://github.com/apache/helix/pull/2390#discussion_r1123958251
##########
helix-core/src/main/java/org/apache/helix/model/Message.java:
##########
@@ -660,6 +666,18 @@ public void setBucketSize(int bucketSize) {
}
}
+ public void setSTRebalanceType(STRebalanceType stRebalanceType) {
+ setAttribute(Attributes.ST_REBALANCE_TYPE, stRebalanceType.name());
+ }
+
+ public STRebalanceType getSTRebalanceType() {
+ String rebalanceTypeStr = getAttribute(Attributes.ST_REBALANCE_TYPE);
+ if (rebalanceTypeStr == null) {
Review Comment:
nit: can be inline with 678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org