You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2017/07/06 09:33:07 UTC
Review Request 60682: Move the Log Search ZK config root to the
connect string
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60682/
-----------------------------------------------------------
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Bugs: AMBARI-21413
https://issues.apache.org/jira/browse/AMBARI-21413
Repository: ambari
Description
-------
Each path that are looked up contain the root in LogSearchConfigZK, so it makes sense to move it into the zk connect string.
Diffs
-----
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java 6d362031ea0a4b48dc8651daa6772e8bf4f1b411
Diff: https://reviews.apache.org/r/60682/diff/1/
Testing
-------
Tested on docker, each REST API end point still works fine.
Thanks,
Miklos Gergely
Re: Review Request 60682: Move the Log Search ZK config root to the
connect string
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60682/#review179824
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On July 6, 2017, 9:33 a.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60682/
> -----------------------------------------------------------
>
> (Updated July 6, 2017, 9:33 a.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-21413
> https://issues.apache.org/jira/browse/AMBARI-21413
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Each path that are looked up contain the root in LogSearchConfigZK, so it makes sense to move it into the zk connect string.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java 6d362031ea0a4b48dc8651daa6772e8bf4f1b411
>
>
> Diff: https://reviews.apache.org/r/60682/diff/1/
>
>
> Testing
> -------
>
> Tested on docker, each REST API end point still works fine.
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 60682: Move the Log Search ZK config root to the
connect string
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60682/#review179767
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On July 6, 2017, 9:33 a.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60682/
> -----------------------------------------------------------
>
> (Updated July 6, 2017, 9:33 a.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-21413
> https://issues.apache.org/jira/browse/AMBARI-21413
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Each path that are looked up contain the root in LogSearchConfigZK, so it makes sense to move it into the zk connect string.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java 6d362031ea0a4b48dc8651daa6772e8bf4f1b411
>
>
> Diff: https://reviews.apache.org/r/60682/diff/1/
>
>
> Testing
> -------
>
> Tested on docker, each REST API end point still works fine.
>
>
> Thanks,
>
> Miklos Gergely
>
>