[GitHub] [pulsar] equanz edited a comment on pull request #10534: [PIP 79][common,broker,client] Change PartitionedTopicStats to support partial partitioned producer

[GitBox <gi...@apache.org>]

equanz edited a comment on pull request #10534:
URL: https://github.com/apache/pulsar/pull/10534#issuecomment-898542014


   @Vanlightly Of course. I think the main issue is stats collecting logic.
   https://github.com/apache/pulsar/blob/3dd9ec528b07ca495a42c020b3bf0824dc67426f/pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/stats/TopicStatsImpl.java#L184-L193
   
   It causes these issues.
   
   1. If each partition has different number of producers, then calculate publisher stats separetelly
      - e.g. if full partitioned producer and partial partitioned producer(or simply single producer) are connected to the partitioned topic which has 2 partitions, then broker calclulates 3 publisher stats each other
      - expect: each partitioned producer is accumulated as single publisher stats
   2. If each partition has same number of producer, then calculate publisher stats as single partitioned producer
     - e.g. if each partition has single producer(all producers were created separetelly), then broker calculates publisher stats as single publisher
     - expect: all producers are accumulated separetelly
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org