You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "BewareMyPower (via GitHub)" <gi...@apache.org> on 2024/06/11 09:36:29 UTC
[PR] Upgrade vcpkg dependencies for the missed boost-format dependency [pulsar-client-cpp]
BewareMyPower opened a new pull request, #427:
URL: https://github.com/apache/pulsar-client-cpp/pull/427
### Motivation
See https://github.com/microsoft/vcpkg/pull/36510
Currently the commit id of the vcpkg submodule is old. With latest dependencies in vcpkg, it requires a `boost-format` dependency to build.
### Modifications
Upgrade the vcpkg submodule to the latest commit at the moment and add the `boost-format` dependency to fix the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade vcpkg dependencies for the missed boost-format dependency [pulsar-client-cpp]
Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower commented on PR #427:
URL: https://github.com/apache/pulsar-client-cpp/pull/427#issuecomment-2162039405
The root cause is that latest's Boost.PropertyTree does not write a line ending in `write_json`. So I updated the Boost version to 1.85 in `dependencies.yaml` as well to avoid behavior inconsistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade vcpkg dependencies for the missed boost-format dependency [pulsar-client-cpp]
Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower commented on PR #427:
URL: https://github.com/apache/pulsar-client-cpp/pull/427#issuecomment-2161033014
There are some failed tests. I'm going to check if they were introduced by an upgraded dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade vcpkg dependencies for the missed boost-format dependency [pulsar-client-cpp]
Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower closed pull request #427: Upgrade vcpkg dependencies for the missed boost-format dependency
URL: https://github.com/apache/pulsar-client-cpp/pull/427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade vcpkg dependencies for the missed boost-format dependency [pulsar-client-cpp]
Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower commented on PR #427:
URL: https://github.com/apache/pulsar-client-cpp/pull/427#issuecomment-2165805554
There is a bug for GCC 4.8 that it does not support [`std::align`](https://en.cppreference.com/w/cpp/memory/align), which is a standard of C++11.
I sent an email to drop GCC 4.8 in the next release (see https://lists.apache.org/thread/7o8hpv1gtoffvzx053wm0ss2s9xt0795), so I will open a PR to drop the support for GCC 4.8 first and then go back to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade vcpkg dependencies for the missed boost-format dependency [pulsar-client-cpp]
Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower commented on PR #427:
URL: https://github.com/apache/pulsar-client-cpp/pull/427#issuecomment-2161086703
It's an issue with the JSON serialization for key-value schema. Maybe caused by the `boost.property_tree` dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org