You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2016/11/13 02:27:31 UTC
[GitHub] incubator-guacamole-client pull request #80: GUACAMOLE-119: Address RAT buil...
GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/80
GUACAMOLE-119: Address RAT build issues
From [GUACAMOLE-119]():
> As revealed by [Apache RAT](https://creadur.apache.org/rat/), several files within the guacamole-client source tree are missing the required headers. The files are too numerous to list here, but suffice to say this should be fixed and RAT should be included as [part of the build](https://creadur.apache.org/rat/apache-rat-plugin/index.html) going forward.
These changes add RAT to the `pom.xml` of all projects within guacamole-client, excluding the following files from checking:
* AngularJS templates (would result in tons of duplicated license comments within the DOM tree)
* JavaScript libraries included in the Guacamole web application (RAT does not recognize their license boilerplate, but `LICENSE` files are included with each, and those *are* recognized)
* JSON files (cannot contain comments at all)
* Plaintext documentation (`CONTRIBUTING`, `README.md`, etc.)
**NOTE:** As this issue is relevant to the 0.9.10-incubating release, this PR uses `staging/0.9.10-incubating` as its basis rather than `master`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-client fix-rat
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/80.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #80
----
commit 27bb5632f537a570d604ca883e47e95242457900
Author: Michael Jumper <mj...@apache.org>
Date: 2016-11-13T01:55:37Z
GUACAMOLE-119: Add Apache RAT validation to build.
commit 322d2ba1447c58159763b618a8a8b8b444509db5
Author: Michael Jumper <mj...@apache.org>
Date: 2016-11-13T01:02:42Z
GUACAMOLE-119: Add Apache license boilerplate to pom.xml.
commit 4241e8c13f8c9701641a991bdedcda66403b5c7d
Author: Michael Jumper <mj...@apache.org>
Date: 2016-11-13T01:56:35Z
GUACAMOLE-119: Add Apache license boilerplate to project assembly XMLs.
commit 44516e4de4d678d0a07525d8c894ed07fbb5645f
Author: Michael Jumper <mj...@apache.org>
Date: 2016-11-13T01:56:54Z
GUACAMOLE-119: Add Apache license boilerplate to example project. Remove META-INF.
commit d19c078280a31853c6c39334f573ebd8e03b67aa
Author: Michael Jumper <mj...@apache.org>
Date: 2016-11-13T01:57:21Z
GUACAMOLE-119: Add Apache license boilerplate to example config files.
commit b483d8afefb2a8921a7a41f70754ad107ae60a80
Author: Michael Jumper <mj...@apache.org>
Date: 2016-11-13T01:57:36Z
GUACAMOLE-119: Add Apache license boilerplate to guacConfigGroup LDAP schema.
commit d78a2d9dad98517ccd11e7e9602545233d5586ea
Author: Michael Jumper <mj...@apache.org>
Date: 2016-11-13T02:05:31Z
GUACAMOLE-119: Move NetBeans-specific .gitignore entries to guacamole project.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #80: GUACAMOLE-119: Address RAT buil...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-client/pull/80
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---