You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by georgekankava <gi...@git.apache.org> on 2016/06/21 08:29:03 UTC
[GitHub] accumulo pull request #114: Multiple code improvements - squid:S1118, squid:...
GitHub user georgekankava opened a pull request:
https://github.com/apache/accumulo/pull/114
Multiple code improvements - squid:S1118, squid:S1155, squid:ClassVariableVisibilityCheck, squid:MissingDeprecatedCheck, squid:S1186
This pull request is focused on resolving occurrences of Sonar rules
squid:S1118 - Utility classes should not have public constructors.
squid:S1155 - Collection.isEmpty() should be used to test for emptiness.
squid:ClassVariableVisibilityCheck - Class variable fields should not have public accessibility.
squid:MissingDeprecatedCheck - Deprecated elements should have both the annotation and the Javadoc tag.
squid:S1186 - Methods should not be empty.
This pull request removes technical debt of 69 minutes.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1118
https://dev.eclipse.org/sonar/rules/show/squid:S1155
https://dev.eclipse.org/sonar/rules/show/squid:ClassVariableVisibilityCheck
https://dev.eclipse.org/sonar/rules/show/squid:MissingDeprecatedCheck
https://dev.eclipse.org/sonar/rules/show/squid:S1186
Please let me know if you have any questions.
George Kankava
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DevFactory/accumulo release/multiple-code-improvements-fix-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/accumulo/pull/114.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #114
----
commit 18d11ed4c4a30bfb517bdb50b4064c91b8d17aa6
Author: George Kankava <ge...@devfactory.com>
Date: 2016-06-20T13:43:28Z
Multiple code improvements - squid:S1118, squid:S1155, squid:ClassVariableVisibilityCheck, squid:MissingDeprecatedCheck, squid:S1186
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #114: Multiple code improvements - squid:S1118, squid:...
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/114#discussion_r67888116
--- Diff: core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java ---
@@ -82,12 +82,20 @@ public Authorizations convert(String value) {
}
public static class Password {
- public byte[] value;
+ private byte[] value;
--- End diff --
This should likely be private final, otherwise, you'll need to deal with the correctness of copying a reference to an array.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #114: Multiple code improvements - squid:S1118, squid:S1155, ...
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/114
Please see the referenced checkstyle failures from the automated builds of your patch:
```
[INFO] --- maven-checkstyle-plugin:2.17:check (check-style) @ accumulo-core ---
[WARNING] src/main/java/org/apache/accumulo/core/client/ClientSideIteratorScanner.java:[288] (javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty description.
[WARNING] src/main/java/org/apache/accumulo/core/client/ClientSideIteratorScanner.java:[300] (javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty description.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #114: Multiple code improvements - squid:S1118, squid:...
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/114#discussion_r67887982
--- Diff: core/src/main/java/org/apache/accumulo/core/bloomfilter/DynamicBloomFilter.java ---
@@ -97,7 +97,7 @@
/**
* Zero-args constructor for the serialization.
*/
- public DynamicBloomFilter() {}
+ public DynamicBloomFilter() {/**default constructor*/}
--- End diff --
I think this is unnecessary
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #114: Multiple code improvements - squid:S1118, squid:S1155, ...
Posted by georgekankava <gi...@git.apache.org>.
Github user georgekankava commented on the issue:
https://github.com/apache/accumulo/pull/114
Closing pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #114: Multiple code improvements - squid:S1118, squid:...
Posted by dlmarion <gi...@git.apache.org>.
Github user dlmarion commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/114#discussion_r67888105
--- Diff: core/src/main/java/org/apache/accumulo/core/bloomfilter/DynamicBloomFilter.java ---
@@ -97,7 +97,7 @@
/**
* Zero-args constructor for the serialization.
*/
- public DynamicBloomFilter() {}
+ public DynamicBloomFilter() {/**default constructor*/}
--- End diff --
Why do we need this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #114: Multiple code improvements - squid:S1118, squid:...
Posted by georgekankava <gi...@git.apache.org>.
Github user georgekankava closed the pull request at:
https://github.com/apache/accumulo/pull/114
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---