You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "kamalcph (via GitHub)" <gi...@apache.org> on 2023/09/12 10:28:24 UTC
[GitHub] [kafka] kamalcph commented on pull request #14373: KAFKA-15453: enable testFencingOnTransactionExpiration
kamalcph commented on PR #14373:
URL: https://github.com/apache/kafka/pull/14373#issuecomment-1715462178
@showuon
> Even though we extends the TransactionsTest, we didn't inherit some changes in the class initialization. And that causes the test doesn't run as we expected, ex: TransactionsTopicPartitionsProp is using 50 in tiered storage case, but it should be 3... etc. Fixed it by inherit all configs in parent class now.
The behaviour is same in our internal branch. While moving the code, I missed it. Thanks for fixing it! I've invited you as collaborator to my branch. You can overlay this change on top of #14347, so that all the tests can be verified in one PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org