You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by Lance Andersen <La...@Sun.COM> on 2005/05/04 20:40:58 UTC
Re: [jira] Created: (DERBY-242)
DatabaseMetaData.supportsGetGeneratedKeys needs to return FALSE,
since Derby only has limited support.
Attached is the patch.
Regards
Lance
Mamta Satoor wrote:
> Hi Lance,
>
> Thanks for taking it. Yes, it is for Embedded Driver.
>
> Mamta
>
> On 4/29/05, Lance J. Andersen <La...@sun.com> wrote:
>
>>I take it this is with the Embedded Driver as it looks like the code for the
>>new Client Driver is returning false.
>>
>>I can take this if no one else wants it.
>>
>>
>>Mamta Satoor wrote:
>>Hi,
>
>
> I think this is a very easy bug to fix. So, if someone is looking
>
>>for
>
> an opportunity to start with a simple bug, this will be a good
>
>>one.
>
>
> Mamta
>
> On 4/26/05, Satheesh Bandaram (JIRA) <de...@db.apache.org>
>
>>wrote:
>
>
>
>>DatabaseMetaData.supportsGetGeneratedKeys needs to return
>>FALSE, since Derby only has limited
>>support.
>
> ------------------------------------------------------------------------------------------------------
>
>
>>Key: DERBY-242
>
> URL:
>
>>http://issues.apache.org/jira/browse/DERBY-242
>
> Project:
>
>>Derby
>
> Type: Bug
> Components: JDBC
> Versions: 10.0.2.0
> Environment: ALL
>
>>Reporter: Satheesh Bandaram
>
> Assigned to: Satheesh Bandaram
> Fix For:
>
>>10.1.0.0
>
>
> Derby only has partial support for retrieving generated
>
>>values.
>
> Because of this, it is desirable to
>
>>make
>
> DatabaseMetaData.supportsGetGeneratedKeys return
>
>>FALSE. One
>
> of the restrictions include Jira entry Derby-201. Till this
>
>>is
>
> fixed, we should change derby to return FALSE for this.
>
> This would also
>
>>match Derby client behavior.
>
>
> --
> This message is automatically generated by
>
>>JIRA.
>
> -
> If you think it was sent incorrectly contact one of the
>
>>administrators:
>>http://issues.apache.org/jira/secure/Administrators.jspa
>
> -
> For
>
>>more information on JIRA, see:
>>http://www.atlassian.com/software/jira
>
>
>
>
>
>
--
Lance Andersen email: Lance.Andersen@sun.com
Sun Microsystems Inc. phone: (781) 442-2037
1 Network Drive, UBUR02-301 fax : (781) 442-1610
Burlington, MA 01803
Re: [jira] Created: (DERBY-242)
DatabaseMetaData.supportsGetGeneratedKeys needs to return FALSE,
since Derby only has limited support.
Posted by "Lance J. Andersen" <La...@Sun.COM>.
All set Satheesh.
Regards
Lance
Satheesh Bandaram wrote:
> Committed this patch. I also searched for all references to
> supportsGetGeneratedKeys() in the test & master files. This was the
> only reference. Lance, can you RESOLVE the Jira entry and then CLOSE
> it, please?
>
> Satheesh
>
> ------------------------------------------------------------------------
> r168176 | bandaram | 2005-05-04 12:50:21 -0700 (Wed, 04 May 2005) | 3
> lines
>
> Derby-242: Make DatabaseMetadata.supportsMultipleOpenResults() return
> FALSE.
>
> Submitted by Lance Anderson. (Lance.Andersen@Sun.COM)
> ------------------------------------------------------------------------
>
> Lance J. Andersen wrote:
>
>> Hi Mamta,
>>
>> The only test I saw and ran was DBMetaDataJdbc30 when I searched the
>> codeline. (You saw my notes on my other failures in jdk14 test run,
>> but this one passed)
>>
>> I also noticed that the other drivers were already set to false.
>>
>> Regards
>> Lance
>>
>> Mamta Satoor wrote:
>>
>>>Hi Lance,
>>>
>>>I looked at the review package and it looks good. Good comments in the
>>>EmbedDatabaseMetaData.java. Just wondered if you ran the existing
>>>tests to make sure nothing got affected by the change.
>>>
>>>Mamta
>>>
>>>On 5/4/05, Lance J. Andersen <La...@sun.com> wrote:
>>>
>>>
>>>>Oh, I forgot to mention that i validated that the dbMetaDataJdbc30 in jdk14
>>>>passed.
>>>>
>>>>
>>>>
>>>>Lance Andersen wrote:
>>>>
>>>>Attached is the patch.
>>>>
>>>>Regards
>>>>Lance
>>>>
>>>>Mamta Satoor wrote:
>>>>Hi Lance,
>>>>
>>>>Thanks for taking it. Yes, it is for Embedded Driver.
>>>>
>>>>Mamta
>>>>
>>>>On 4/29/05, Lance J. Andersen <La...@sun.com> wrote:
>>>>
>>>>I take it this is with the Embedded Driver as it looks like the code for the
>>>>new Client Driver is returning false.
>>>>
>>>>I can take this if no one else wants it.
>>>>
>>>>
>>>>Mamta Satoor wrote:
>>>>Hi,
>>>>
>>>>
>>>>I think this is a very easy bug to fix. So, if someone is looking
>>>>
>>>>for
>>>>
>>>>an opportunity to start with a simple bug, this will be a good
>>>>
>>>>one.
>>>>
>>>>
>>>>Mamta
>>>>
>>>>On 4/26/05, Satheesh Bandaram (JIRA) <de...@db.apache.org>
>>>>
>>>>wrote:
>>>>
>>>>
>>>>
>>>>DatabaseMetaData.supportsGetGeneratedKeys needs to return
>>>>FALSE, since Derby only has limited
>>>>support.
>>>>
>>>>------------------------------------------------------------------------------------------------------
>>>>
>>>>
>>>>Key: DERBY-242
>>>>
>>>> URL:
>>>>
>>>>http://issues.apache.org/jira/browse/DERBY-242
>>>>
>>>> Project:
>>>>
>>>>Derby
>>>>
>>>> Type: Bug
>>>> Components: JDBC
>>>> Versions: 10.0.2.0
>>>>Environment: ALL
>>>>
>>>>Reporter: Satheesh Bandaram
>>>>
>>>>Assigned to: Satheesh Bandaram
>>>> Fix For:
>>>>
>>>>10.1.0.0
>>>>
>>>>
>>>>Derby only has partial support for retrieving generated
>>>>
>>>>values.
>>>>
>>>>Because of this, it is desirable to
>>>>
>>>>make
>>>>
>>>>DatabaseMetaData.supportsGetGeneratedKeys return
>>>>
>>>>FALSE. One
>>>>
>>>>of the restrictions include Jira entry Derby-201. Till this
>>>>
>>>>is
>>>>
>>>>fixed, we should change derby to return FALSE for this.
>>>>
>>>>This would also
>>>>
>>>>match Derby client behavior.
>>>>
>>>>
>>>>--
>>>>This message is automatically generated by
>>>>
>>>>JIRA.
>>>>
>>>>-
>>>>If you think it was sent incorrectly contact one of the
>>>>
>>>>administrators:
>>>>http://issues.apache.org/jira/secure/Administrators.jspa
>>>>
>>>>-
>>>>For
>>>>
>>>>more information on JIRA, see:
>>>>http://www.atlassian.com/software/jira
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>________________________________
>>>>
>>>>
>>>>
>>>Index:
>>>
>>>
>>>>java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java
>>>>
>>>>
>>>===================================================================
>>>---
>>>
>>>
>>>>java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java
>>>>(revision 168122)
>>>>
>>>>
>>>+++
>>>
>>>
>>>>java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java
>>>>(working copy)
>>>>
>>>>
>>>@@ -2880,7 +2880,13 @@
>>> */
>>> public boolean
>>>
>>>
>>>>supportsGetGeneratedKeys()
>>>>
>>>>
>>> {
>>>- return true;
>>>+ /*
>>>+ * Currently reverting
>>>
>>>
>>>>the returned value to false until there
>>>>
>>>>
>>>+ * is more support for
>>>
>>>
>>>>autogenerated keys in Derby.
>>>>
>>>>
>>>+ * (such as support for specifying the
>>>
>>>
>>>>returned columns for
>>>>
>>>>
>>>+ * the autogenerated key)
>>>+ */
>>>+ return false;
>>> }
>>>
>>>
>>>
>>>>/**
>>>>
>>>>
>>>Index:
>>>
>>>
>>>>java/testing/org/apache/derbyTesting/functionTests/master/dbMetaDataJdbc30.out
>>>>
>>>>
>>>===================================================================
>>>---
>>>
>>>
>>>>java/testing/org/apache/derbyTesting/functionTests/master/dbMetaDataJdbc30.out
>>>>(revision 168122)
>>>>
>>>>
>>>+++
>>>
>>>
>>>>java/testing/org/apache/derbyTesting/functionTests/master/dbMetaDataJdbc30.out
>>>>(working copy)
>>>>
>>>>
>>>@@ -4,7 +4,7 @@
>>> supportsSavepoints() : true
>>>
>>>
>>>>supportsNamedParameters() : false
>>>>
>>>>
>>> supportsMultipleOpenResults() :
>>>
>>>
>>>>true
>>>>
>>>>
>>>-supportsGetGeneratedKeys() : true
>>>+supportsGetGeneratedKeys() : false
>>>
>>>
>>>>supportsResultSetHoldability(HOLD_CURSORS_OVER_COMMIT) :
>>>>true
>>>>
>>>>
>>> supportsResultSetHoldability(CLOSE_CURSORS_AT_COMMIT)
>>>
>>>
>>>>: true
>>>>
>>>>
>>> getJDBCMajorVersion() : 3
>>>
>>>>
>>>
>>>
Re: [jira] Created: (DERBY-242)
DatabaseMetaData.supportsGetGeneratedKeys needs to return FALSE,
since Derby only has limited support.
Posted by "Lance J. Andersen" <La...@Sun.COM>.
Hi Mamta,
The only test I saw and ran was DBMetaDataJdbc30 when I searched the
codeline. (You saw my notes on my other failures in jdk14 test run, but
this one passed)
I also noticed that the other drivers were already set to false.
Regards
Lance
Mamta Satoor wrote:
>Hi Lance,
>
>I looked at the review package and it looks good. Good comments in the
>EmbedDatabaseMetaData.java. Just wondered if you ran the existing
>tests to make sure nothing got affected by the change.
>
>Mamta
>
>On 5/4/05, Lance J. Andersen <La...@sun.com> wrote:
>
>
>>Oh, I forgot to mention that i validated that the dbMetaDataJdbc30 in jdk14
>>passed.
>>
>>
>>
>>Lance Andersen wrote:
>>
>>Attached is the patch.
>>
>>Regards
>>Lance
>>
>>Mamta Satoor wrote:
>>Hi Lance,
>>
>>Thanks for taking it. Yes, it is for Embedded Driver.
>>
>>Mamta
>>
>>On 4/29/05, Lance J. Andersen <La...@sun.com> wrote:
>>
>>I take it this is with the Embedded Driver as it looks like the code for the
>>new Client Driver is returning false.
>>
>>I can take this if no one else wants it.
>>
>>
>>Mamta Satoor wrote:
>>Hi,
>>
>>
>>I think this is a very easy bug to fix. So, if someone is looking
>>
>>for
>>
>>an opportunity to start with a simple bug, this will be a good
>>
>>one.
>>
>>
>>Mamta
>>
>>On 4/26/05, Satheesh Bandaram (JIRA) <de...@db.apache.org>
>>
>>wrote:
>>
>>
>>
>>DatabaseMetaData.supportsGetGeneratedKeys needs to return
>>FALSE, since Derby only has limited
>>support.
>>
>>------------------------------------------------------------------------------------------------------
>>
>>
>>Key: DERBY-242
>>
>> URL:
>>
>>http://issues.apache.org/jira/browse/DERBY-242
>>
>> Project:
>>
>>Derby
>>
>> Type: Bug
>> Components: JDBC
>> Versions: 10.0.2.0
>>Environment: ALL
>>
>>Reporter: Satheesh Bandaram
>>
>>Assigned to: Satheesh Bandaram
>> Fix For:
>>
>>10.1.0.0
>>
>>
>>Derby only has partial support for retrieving generated
>>
>>values.
>>
>>Because of this, it is desirable to
>>
>>make
>>
>>DatabaseMetaData.supportsGetGeneratedKeys return
>>
>>FALSE. One
>>
>>of the restrictions include Jira entry Derby-201. Till this
>>
>>is
>>
>>fixed, we should change derby to return FALSE for this.
>>
>>This would also
>>
>>match Derby client behavior.
>>
>>
>>--
>>This message is automatically generated by
>>
>>JIRA.
>>
>>-
>>If you think it was sent incorrectly contact one of the
>>
>>administrators:
>>http://issues.apache.org/jira/secure/Administrators.jspa
>>
>>-
>>For
>>
>>more information on JIRA, see:
>>http://www.atlassian.com/software/jira
>>
>>
>>
>>
>>
>>
>>
>>
>>________________________________
>>
>>
>>
>Index:
>
>
>>java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java
>>
>>
>===================================================================
>---
>
>
>>java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java
>>(revision 168122)
>>
>>
>+++
>
>
>>java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java
>>(working copy)
>>
>>
>@@ -2880,7 +2880,13 @@
> */
> public boolean
>
>
>>supportsGetGeneratedKeys()
>>
>>
> {
>- return true;
>+ /*
>+ * Currently reverting
>
>
>>the returned value to false until there
>>
>>
>+ * is more support for
>
>
>>autogenerated keys in Derby.
>>
>>
>+ * (such as support for specifying the
>
>
>>returned columns for
>>
>>
>+ * the autogenerated key)
>+ */
>+ return false;
> }
>
>
>
>>/**
>>
>>
>Index:
>
>
>>java/testing/org/apache/derbyTesting/functionTests/master/dbMetaDataJdbc30.out
>>
>>
>===================================================================
>---
>
>
>>java/testing/org/apache/derbyTesting/functionTests/master/dbMetaDataJdbc30.out
>>(revision 168122)
>>
>>
>+++
>
>
>>java/testing/org/apache/derbyTesting/functionTests/master/dbMetaDataJdbc30.out
>>(working copy)
>>
>>
>@@ -4,7 +4,7 @@
> supportsSavepoints() : true
>
>
>>supportsNamedParameters() : false
>>
>>
> supportsMultipleOpenResults() :
>
>
>>true
>>
>>
>-supportsGetGeneratedKeys() : true
>+supportsGetGeneratedKeys() : false
>
>
>>supportsResultSetHoldability(HOLD_CURSORS_OVER_COMMIT) :
>>true
>>
>>
> supportsResultSetHoldability(CLOSE_CURSORS_AT_COMMIT)
>
>
>>: true
>>
>>
> getJDBCMajorVersion() : 3
>
>>
>
>
Re: [jira] Created: (DERBY-242) DatabaseMetaData.supportsGetGeneratedKeys needs to return FALSE, since Derby only has limited support.
Posted by Mamta Satoor <ms...@gmail.com>.
Hi Lance,
I looked at the review package and it looks good. Good comments in the
EmbedDatabaseMetaData.java. Just wondered if you ran the existing
tests to make sure nothing got affected by the change.
Mamta
On 5/4/05, Lance J. Andersen <La...@sun.com> wrote:
> Oh, I forgot to mention that i validated that the dbMetaDataJdbc30 in jdk14
> passed.
>
>
>
> Lance Andersen wrote:
>
> Attached is the patch.
>
> Regards
> Lance
>
> Mamta Satoor wrote:
> Hi Lance,
>
> Thanks for taking it. Yes, it is for Embedded Driver.
>
> Mamta
>
> On 4/29/05, Lance J. Andersen <La...@sun.com> wrote:
>
> I take it this is with the Embedded Driver as it looks like the code for the
> new Client Driver is returning false.
>
> I can take this if no one else wants it.
>
>
> Mamta Satoor wrote:
> Hi,
>
>
> I think this is a very easy bug to fix. So, if someone is looking
>
> for
>
> an opportunity to start with a simple bug, this will be a good
>
> one.
>
>
> Mamta
>
> On 4/26/05, Satheesh Bandaram (JIRA) <de...@db.apache.org>
>
> wrote:
>
>
>
> DatabaseMetaData.supportsGetGeneratedKeys needs to return
> FALSE, since Derby only has limited
> support.
>
> ------------------------------------------------------------------------------------------------------
>
>
> Key: DERBY-242
>
> URL:
>
> http://issues.apache.org/jira/browse/DERBY-242
>
> Project:
>
> Derby
>
> Type: Bug
> Components: JDBC
> Versions: 10.0.2.0
> Environment: ALL
>
> Reporter: Satheesh Bandaram
>
> Assigned to: Satheesh Bandaram
> Fix For:
>
> 10.1.0.0
>
>
> Derby only has partial support for retrieving generated
>
> values.
>
> Because of this, it is desirable to
>
> make
>
> DatabaseMetaData.supportsGetGeneratedKeys return
>
> FALSE. One
>
> of the restrictions include Jira entry Derby-201. Till this
>
> is
>
> fixed, we should change derby to return FALSE for this.
>
> This would also
>
> match Derby client behavior.
>
>
> --
> This message is automatically generated by
>
> JIRA.
>
> -
> If you think it was sent incorrectly contact one of the
>
> administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
>
> -
> For
>
> more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>
>
>
>
>
>
>
> ________________________________
>
Index:
> java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java
===================================================================
---
> java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java
> (revision 168122)
+++
> java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java
> (working copy)
@@ -2880,7 +2880,13 @@
*/
public boolean
> supportsGetGeneratedKeys()
{
- return true;
+ /*
+ * Currently reverting
> the returned value to false until there
+ * is more support for
> autogenerated keys in Derby.
+ * (such as support for specifying the
> returned columns for
+ * the autogenerated key)
+ */
+ return false;
}
> /**
Index:
> java/testing/org/apache/derbyTesting/functionTests/master/dbMetaDataJdbc30.out
===================================================================
---
> java/testing/org/apache/derbyTesting/functionTests/master/dbMetaDataJdbc30.out
> (revision 168122)
+++
> java/testing/org/apache/derbyTesting/functionTests/master/dbMetaDataJdbc30.out
> (working copy)
@@ -4,7 +4,7 @@
supportsSavepoints() : true
> supportsNamedParameters() : false
supportsMultipleOpenResults() :
> true
-supportsGetGeneratedKeys() : true
+supportsGetGeneratedKeys() : false
> supportsResultSetHoldability(HOLD_CURSORS_OVER_COMMIT) :
> true
supportsResultSetHoldability(CLOSE_CURSORS_AT_COMMIT)
> : true
getJDBCMajorVersion() : 3
>
Re: [jira] Created: (DERBY-242)
DatabaseMetaData.supportsGetGeneratedKeys needs to return FALSE,
since Derby only has limited support.
Posted by "Lance J. Andersen" <La...@Sun.COM>.
Oh, I forgot to mention that i validated that the dbMetaDataJdbc30 in
jdk14 passed.
Lance Andersen wrote:
> Attached is the patch.
>
> Regards
> Lance
>
> Mamta Satoor wrote:
>
>> Hi Lance,
>>
>> Thanks for taking it. Yes, it is for Embedded Driver.
>>
>> Mamta
>>
>> On 4/29/05, Lance J. Andersen <La...@sun.com> wrote:
>>
>>> I take it this is with the Embedded Driver as it looks like the code
>>> for the
>>> new Client Driver is returning false.
>>>
>>> I can take this if no one else wants it.
>>>
>>>
>>> Mamta Satoor wrote:
>>> Hi,
>>
>>
>>
>> I think this is a very easy bug to fix. So, if someone is looking
>>
>>> for
>>
>>
>> an opportunity to start with a simple bug, this will be a good
>>
>>> one.
>>
>>
>>
>> Mamta
>>
>> On 4/26/05, Satheesh Bandaram (JIRA) <de...@db.apache.org>
>>
>>> wrote:
>>
>>
>>
>>
>>> DatabaseMetaData.supportsGetGeneratedKeys needs to return
>>> FALSE, since Derby only has limited
>>> support.
>>
>>
>> ------------------------------------------------------------------------------------------------------
>>
>>
>>
>>> Key: DERBY-242
>>
>>
>> URL:
>>
>>> http://issues.apache.org/jira/browse/DERBY-242
>>
>>
>> Project:
>>
>>> Derby
>>
>>
>> Type: Bug
>> Components: JDBC
>> Versions: 10.0.2.0
>> Environment: ALL
>>
>>> Reporter: Satheesh Bandaram
>>
>>
>> Assigned to: Satheesh Bandaram
>> Fix For:
>>
>>> 10.1.0.0
>>
>>
>>
>> Derby only has partial support for retrieving generated
>>
>>> values.
>>
>>
>> Because of this, it is desirable to
>>
>>> make
>>
>>
>> DatabaseMetaData.supportsGetGeneratedKeys return
>>
>>> FALSE. One
>>
>>
>> of the restrictions include Jira entry Derby-201. Till this
>>
>>> is
>>
>>
>> fixed, we should change derby to return FALSE for this.
>>
>> This would also
>>
>>> match Derby client behavior.
>>
>>
>>
>> --
>> This message is automatically generated by
>>
>>> JIRA.
>>
>>
>> -
>> If you think it was sent incorrectly contact one of the
>>
>>> administrators:
>>> http://issues.apache.org/jira/secure/Administrators.jspa
>>
>>
>> -
>> For
>>
>>> more information on JIRA, see:
>>> http://www.atlassian.com/software/jira
>>
>>
>>
>>
>>
>>
>>
>
>
>------------------------------------------------------------------------
>
>Index: java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java
>===================================================================
>--- java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java (revision 168122)
>+++ java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java (working copy)
>@@ -2880,7 +2880,13 @@
> */
> public boolean supportsGetGeneratedKeys()
> {
>- return true;
>+ /*
>+ * Currently reverting the returned value to false until there
>+ * is more support for autogenerated keys in Derby.
>+ * (such as support for specifying the returned columns for
>+ * the autogenerated key)
>+ */
>+ return false;
> }
>
> /**
>Index: java/testing/org/apache/derbyTesting/functionTests/master/dbMetaDataJdbc30.out
>===================================================================
>--- java/testing/org/apache/derbyTesting/functionTests/master/dbMetaDataJdbc30.out (revision 168122)
>+++ java/testing/org/apache/derbyTesting/functionTests/master/dbMetaDataJdbc30.out (working copy)
>@@ -4,7 +4,7 @@
> supportsSavepoints() : true
> supportsNamedParameters() : false
> supportsMultipleOpenResults() : true
>-supportsGetGeneratedKeys() : true
>+supportsGetGeneratedKeys() : false
> supportsResultSetHoldability(HOLD_CURSORS_OVER_COMMIT) : true
> supportsResultSetHoldability(CLOSE_CURSORS_AT_COMMIT) : true
> getJDBCMajorVersion() : 3
>
>