You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by medcv <gi...@git.apache.org> on 2018/05/18 23:02:22 UTC
[GitHub] flink pull request #6044: [FLINK-1044] Website: Offer a zip archive with a p...
GitHub user medcv opened a pull request:
https://github.com/apache/flink/pull/6044
[FLINK-1044] Website: Offer a zip archive with a pre-setup user project
## What is the purpose of the change
This PR will run two tests to build Java and Scala quickstart packages. After compiling and packaging the jar files, it submit the wordcount class to a cluster and validate the output. At the very end it should upload the jar files to `https://flink.apache.org/q` server. Last part not working as I need more details to find out how to upload the .jar files to the flink server and I am looking for help from reviewers to point me to the right direction.
## Brief change log
- *add two new e2e tests *
- *Modify run-pre-commit-tests*
## Verifying this change
This change added tests and can be verified as follows:
Run test_build_quickstart_java.sh and test_build_quickstart_scala.sh to verify this change
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/medcv/flink FLINK-1044
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6044.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6044
----
commit dd59a8df1662bd1fa06dbfa220802e20a12945c3
Author: Yadan.JS <y_...@...>
Date: 2018-05-18T22:11:40Z
[FLINK-1044] Website: Offer a zip archive with a pre-setup user project
----
---
[GitHub] flink pull request #6044: [FLINK-1044] Website: Offer a zip archive with a p...
Posted by medcv <gi...@git.apache.org>.
Github user medcv closed the pull request at:
https://github.com/apache/flink/pull/6044
---
[GitHub] flink issue #6044: [FLINK-1044] Website: Offer a zip archive with a pre-setu...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6044
@medcv yes we should test the scala quickstarts as well.
---
[GitHub] flink issue #6044: [FLINK-1044] Website: Offer a zip archive with a pre-setu...
Posted by medcv <gi...@git.apache.org>.
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6044
@StephanEwen I would appreciate if you review this
---
[GitHub] flink issue #6044: [FLINK-1044] Website: Offer a zip archive with a pre-setu...
Posted by medcv <gi...@git.apache.org>.
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6044
@zentol Thanks for the review.
Make sense to build this `quickstarts.zip` package on Jenkins but the main concern was test the `.zip` package (included all dependencies) before uploading it on site. As end2end test for quickstarts already got merged then it should be fine.
I will close this PR.
Quick side note:
I looked at the end2end test for quickstarts (`test-quickstarts.sh`) and it has a test for Java version. Do you think it make sense we add a ent2end test for Scala version of quickstarts also?
---
[GitHub] flink issue #6044: [FLINK-1044] Website: Offer a zip archive with a pre-setu...
Posted by medcv <gi...@git.apache.org>.
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6044
@zentol
Ok, I created a Jira ticket for Scala Quickstarts end2end test and will make a PR for it.
---