You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/04/02 00:13:12 UTC
[GitHub] [trafficcontrol] zrhoffman opened a new pull request #4587: Make
_postinstall work in Perl 5.26
zrhoffman opened a new pull request #4587: Make _postinstall work in Perl 5.26
URL: https://github.com/apache/trafficcontrol/pull/4587
<!--
************ STOP!! ************
If this Pull Request is intended to fix a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
## What does this PR (Pull Request) do?
<!-- Explain the changes you made here. If this fixes an Issue, identify it by
replacing the text in the checkbox item with the Issue number e.g.
- [x] This PR fixes #9001 OR is not related to any Issue
^ This will automatically close Issue number 9001 when the Pull Request is
merged (The '#' is important).
Be sure you check the box properly, see the "The following criteria are ALL
met by this PR" section for details.
-->
- [x] This PR fixes #4577<!-- You can check for an issue here: https://github.com/apache/trafficcontrol/issues -->
- Documentation is not necessary because intended behavior does not change.
- See the "What is the best way to verify this PR?" section for a test
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this
Pull Request. Also, feel free to add the name of a tool or script that is
affected but not on the list.
Additionally, if this Pull Request does NOT affect documentation, please
explain why documentation is not required. -->
- Traffic Ops
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your Pull Request. If
it includes tests (and most should), outline here the steps needed to run the
tests. If not, lay out the manual testing procedure and please explain why
tests are unnecessary for this Pull Request. -->
1. Rebuild the Traffic Ops Perl container and start CDN-in-a-Box
2. Run this and verify it worked:
```bash
<<'BASH_COMMANDS' docker-compose exec -T trafficops-perl bash;
yum -y install centos-release-scl;
yum -y install rh-perl526;
sed -i 's|".*ciphers.*"|"https://[::]:60443?cert=/etc/pki/tls/certs/localhost.crt\&key=/etc/pki/tls/private/localhost.key\&verify=0x00\&ciphers=AES128-GCM-SHA256:HIGH:!RC4:!MD5:!aNULL:!EDH:!ED"|g' conf/cdn.conf;
rm -r local;
<<'SCL_COMMANDS' scl enable rh-perl526 bash;
cpanm -l ./local Carton;
POSTGRES_HOME=/usr/pgsql-9.6 PERL5LIB=$(pwd)/local/lib/perl5 ./local/bin/carton;
<<'POSTINSTALL_INPUT' scl enable rh-perl526 rh-perl526 ../install/bin/_postinstall;
Pg
traffic_ops
db.infra.ciab.test
5432
traffic_ops
twelve
twelve
traffic_ops
twelve
twelve
no
admin
twelve
twelve
yes
US
CO
Denver
Comcast
Traffic Control
trafficops.infra.ciab.test
rsapass
rsapass
https://trafficops.infra.ciab.test
CDN-in-a-Box
mycdn.ciab.test
yes
1
443
12
http://trafficops.infra.ciab.test:3000
/opt/traffic_ops/app/conf/ldap.conf
POSTINSTALL_INPUT
SCL_COMMANDS
BASH_COMMANDS
```
## If this is a bug fix, what versions of Traffic Control are affected?
<!-- If this PR fixes a bug, please list here all of the affected versions - to
the best of your knowledge. It's also pretty helpful to include a commit hash
of where 'master' is at the time this PR is opened (if it affects master),
because what 'master' means will change over time. For example, if this PR
fixes a bug that's present in master (at commit hash '2697ebac'), in v3.0.0,
and in the current 3.0.1 Release candidate (e.g. RC1), then this list would
look like:
- master (9a7db19f5e)
- 4.0.0
If you don't know what other versions might have this bug, AND don't know how
to find the commit hash of 'master', then feel free to leave this section
blank (or, preferably, delete it entirely).
-->
- master (9a7db19f5e)
- 4.0.0
## The following criteria are ALL met by this PR
<!-- Check the boxes to signify that the associated statement is true. To
"check a box", replace the space inside of the square brackets with an 'x'.
e.g.
- [ x] <- Wrong
- [x ] <- Wrong
- [] <- Wrong
- [*] <- Wrong
- [x] <- Correct!
-->
- [x] This PR includes tests
- [x] I have explained why documentation is unnecessary
- [x] An update to CHANGELOG.md is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR does not include a database migration
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] rawlinp commented on issue #4587: Make
_postinstall work in Perl 5.26
Posted by GitBox <gi...@apache.org>.
rawlinp commented on issue #4587: Make _postinstall work in Perl 5.26
URL: https://github.com/apache/trafficcontrol/pull/4587#issuecomment-610641760
add to whitelist
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] zrhoffman commented on issue #4587: Make
_postinstall work in Perl 5.26
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on issue #4587: Make _postinstall work in Perl 5.26
URL: https://github.com/apache/trafficcontrol/pull/4587#issuecomment-611833786
A couple of the lines were Perl 5.20+ syntactic sugar. Broke out into separate lines in bc9255c9ce, now it is compatible with both Perl 5.16 and Perl 5.26.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] rawlinp merged pull request #4587: Make
_postinstall work in Perl 5.26
Posted by GitBox <gi...@apache.org>.
rawlinp merged pull request #4587: Make _postinstall work in Perl 5.26
URL: https://github.com/apache/trafficcontrol/pull/4587
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services