You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "apeskov (via GitHub)" <gi...@apache.org> on 2023/04/28 13:19:19 UTC

[GitHub] [tvm] apeskov opened a new pull request, #14741: [TIR] Keep block annotations from tensorization

apeskov opened a new pull request, #14741:
URL: https://github.com/apache/tvm/pull/14741

   TIR TensorIntrin implementation may contains some annotation. Current logic will skip all existing annotations. But in some cases it may be helpful to transfer annotations to resulting schedule.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] apeskov commented on a diff in pull request #14741: [TIR] Keep block annotations from tensorization

Posted by "apeskov (via GitHub)" <gi...@apache.org>.
apeskov commented on code in PR #14741:
URL: https://github.com/apache/tvm/pull/14741#discussion_r1184842299


##########
src/tir/schedule/primitive/blockize_tensorize.cc:
##########
@@ -604,6 +604,15 @@ void Tensorize(ScheduleState self, const StmtSRef& sref, const TensorIntrin& int
     BlockNode* block = block_realize.CopyOnWrite()->block.CopyOnWrite();
     block->body = impl_block->body;
     block->match_buffers = std::move(match_buffer_regions);
+    for (auto [key, val] : impl_block->annotations) {

Review Comment:
   updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] echuraev merged pull request #14741: [TIR] Keep block annotations from tensorization

Posted by "echuraev (via GitHub)" <gi...@apache.org>.
echuraev merged PR #14741:
URL: https://github.com/apache/tvm/pull/14741


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] echuraev commented on a diff in pull request #14741: [TIR] Keep block annotations from tensorization

Posted by "echuraev (via GitHub)" <gi...@apache.org>.
echuraev commented on code in PR #14741:
URL: https://github.com/apache/tvm/pull/14741#discussion_r1184221091


##########
src/tir/schedule/primitive/blockize_tensorize.cc:
##########
@@ -604,6 +604,15 @@ void Tensorize(ScheduleState self, const StmtSRef& sref, const TensorIntrin& int
     BlockNode* block = block_realize.CopyOnWrite()->block.CopyOnWrite();
     block->body = impl_block->body;
     block->match_buffers = std::move(match_buffer_regions);
+    for (auto [key, val] : impl_block->annotations) {

Review Comment:
   nit: Can we use `auto&` instead of `auto`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #14741: [TIR] Keep block annotations from tensorization

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14741:
URL: https://github.com/apache/tvm/pull/14741#issuecomment-1527553466

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Hzfengsy, @junrushao, @quic-sanirudh, @shingjan <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org