You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nlpcraft.apache.org by Justin Mclean <ju...@classsoftware.com> on 2020/05/02 06:01:24 UTC
Re: [VOTE] Release Apache NLPCraft (Incubating) 0.5.0
HI,
I know the vote has all ready passed but I can see a couple of issues here:
- LICENSE is missing the appendix
- As noted the NOTICE is not correct. License are not lined in NOTICE they are licensed in LICENSE and need to be the full text. Dependancies don’t need to be listed only that that are bundled in the release.
- The release included what looks like to be compiled code, this is generally not allowed in a source release [1]
- LICENSE is missing the license of this file [2]
Thanks,
Justin
1. ./src/main/resources/opennlp/*.bin
2. https://github.com/peet/hashids.java/blob/master/src/HashidsJava/Hashids.java
Re: [VOTE] Release Apache NLPCraft (Incubating) 0.5.0
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> thanks a lot for the comments and keeping us honest. I want to make sure we are on the same page: do you see these issues as critical or they can be addressed in the consequent release?
Next release is fine by me.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache NLPCraft (Incubating) 0.5.0
Posted by Konstantin Boudnik <co...@apache.org>.
Justin,
thanks a lot for the comments and keeping us honest. I want to make sure
we are on the same page: do you see these issues as critical or they can
be addressed in the consequent release?
Thanks,
On 2020-05-05 06:02, Justin Mclean wrote:
> Hi,
>
>> Fixed in master. However, there are still questions on hoThw NOTICE file
>> should look like for binary releases.
> Generally the way that is handles is too have seperate NOTICE (and LICENSE) files one for teh source release and one for the binary convienance.
>
>> These are the model files shipped with Apache OpenNLP (data, not code).
> Perhaps call them “.dat” rather than “.bin”?
>
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
--
With regards,
Cos
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache NLPCraft (Incubating) 0.5.0
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Fixed in master. However, there are still questions on hoThw NOTICE file
> should look like for binary releases.
Generally the way that is handles is too have seperate NOTICE (and LICENSE) files one for teh source release and one for the binary convienance.
> These are the model files shipped with Apache OpenNLP (data, not code).
Perhaps call them “.dat” rather than “.bin”?
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache NLPCraft (Incubating) 0.5.0
Posted by Aaron Radzinski <ar...@datalingvo.com>.
Justin,
Thank you for noticing this. See below...
--
Aaron Radzinski
On Fri, May 1, 2020 at 11:01 PM Justin Mclean <ju...@classsoftware.com>
wrote:
> HI,
>
> I know the vote has all ready passed but I can see a couple of issues
> here:
> - LICENSE is missing the appendix
>
Fixed in master.
- As noted the NOTICE is not correct. License are not lined in NOTICE they
> are licensed in LICENSE and need to be the full text. Dependancies don’t
> need to be listed only that that are bundled in the release.
>
Fixed in master. However, there are still questions on hoThw NOTICE file
should look like for binary releases.
- The release included what looks like to be compiled code, this is
> generally not allowed in a source release [1]
>
These are the model files shipped with Apache OpenNLP (data, not code).
> - LICENSE is missing the license of this file [2]
>
Fixed in master.
> Thanks,
> Justin
>
> 1. ./src/main/resources/opennlp/*.bin
> 2.
> https://github.com/peet/hashids.java/blob/master/src/HashidsJava/Hashids.java
>
>
Re: [VOTE] Release Apache NLPCraft (Incubating) 0.5.0
Posted by Aaron Radzinski <ar...@datalingvo.com>.
Justin,
Thank you for noticing this. See below...
--
Aaron Radzinski
On Fri, May 1, 2020 at 11:01 PM Justin Mclean <ju...@classsoftware.com>
wrote:
> HI,
>
> I know the vote has all ready passed but I can see a couple of issues
> here:
> - LICENSE is missing the appendix
>
Fixed in master.
- As noted the NOTICE is not correct. License are not lined in NOTICE they
> are licensed in LICENSE and need to be the full text. Dependancies don’t
> need to be listed only that that are bundled in the release.
>
Fixed in master. However, there are still questions on hoThw NOTICE file
should look like for binary releases.
- The release included what looks like to be compiled code, this is
> generally not allowed in a source release [1]
>
These are the model files shipped with Apache OpenNLP (data, not code).
> - LICENSE is missing the license of this file [2]
>
Fixed in master.
> Thanks,
> Justin
>
> 1. ./src/main/resources/opennlp/*.bin
> 2.
> https://github.com/peet/hashids.java/blob/master/src/HashidsJava/Hashids.java
>
>