You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2024/03/07 19:20:39 UTC
[Impala-ASF-CR] Impala-12798: Tolerate floationg point precision for regr intercept() TIMESTAMP test
pranav.lodha@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21117
Change subject: Impala-12798: Tolerate floationg point precision for regr_intercept() TIMESTAMP test
......................................................................
Impala-12798: Tolerate floationg point precision for regr_intercept()
TIMESTAMP test
The patch focuses on making sure that the regr_intercept() tests are
uniform across different systems by adding tolerance for floating
point precision.
Change-Id: I937dec4cdf9557c9af7734c8793f0aa6e8d29889
---
M testdata/workloads/functional-query/queries/QueryTest/aggregation.test
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/21117/1
--
To view, visit http://gerrit.cloudera.org:8080/21117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I937dec4cdf9557c9af7734c8793f0aa6e8d29889
Gerrit-Change-Number: 21117
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-12798: Tolerate floationg point precision for regr intercept() TIMESTAMP test
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21117 )
Change subject: IMPALA-12798: Tolerate floationg point precision for regr_intercept() TIMESTAMP test
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I937dec4cdf9557c9af7734c8793f0aa6e8d29889
Gerrit-Change-Number: 21117
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 20:16:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Impala-12798: Tolerate floationg point precision for regr intercept() TIMESTAMP test
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21117 )
Change subject: Impala-12798: Tolerate floationg point precision for regr_intercept() TIMESTAMP test
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21117/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21117/1//COMMIT_MSG@7
PS1, Line 7: Impala-12798
nit: IMPALA-12798
--
To view, visit http://gerrit.cloudera.org:8080/21117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I937dec4cdf9557c9af7734c8793f0aa6e8d29889
Gerrit-Change-Number: 21117
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 19:23:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12798: Tolerate floationg point precision for regr intercept() TIMESTAMP test
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21117 )
Change subject: IMPALA-12798: Tolerate floationg point precision for regr_intercept() TIMESTAMP test
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I937dec4cdf9557c9af7734c8793f0aa6e8d29889
Gerrit-Change-Number: 21117
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 19:44:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12798: Tolerate floationg point precision for regr intercept() TIMESTAMP test
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21117 )
Change subject: IMPALA-12798: Tolerate floationg point precision for regr_intercept() TIMESTAMP test
......................................................................
Patch Set 2: Code-Review+2
Thanks Daniel for checking this. Change my vote to +2.
--
To view, visit http://gerrit.cloudera.org:8080/21117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I937dec4cdf9557c9af7734c8793f0aa6e8d29889
Gerrit-Change-Number: 21117
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 20:19:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12798: Tolerate floationg point precision for regr intercept() TIMESTAMP test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21117 )
Change subject: IMPALA-12798: Tolerate floationg point precision for regr_intercept() TIMESTAMP test
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/15446/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I937dec4cdf9557c9af7734c8793f0aa6e8d29889
Gerrit-Change-Number: 21117
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 19:48:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12798: Tolerate floationg point precision for regr intercept() TIMESTAMP test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21117 )
Change subject: IMPALA-12798: Tolerate floationg point precision for regr_intercept() TIMESTAMP test
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I937dec4cdf9557c9af7734c8793f0aa6e8d29889
Gerrit-Change-Number: 21117
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 20:19:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12798: Tolerate floationg point precision for regr intercept() TIMESTAMP test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21117 )
Change subject: IMPALA-12798: Tolerate floationg point precision for regr_intercept() TIMESTAMP test
......................................................................
IMPALA-12798: Tolerate floationg point precision for regr_intercept()
TIMESTAMP test
The patch focuses on making sure that the regr_intercept() tests are
uniform across different systems by adding tolerance for floating
point precision.
Change-Id: I937dec4cdf9557c9af7734c8793f0aa6e8d29889
Reviewed-on: http://gerrit.cloudera.org:8080/21117
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/aggregation.test
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I937dec4cdf9557c9af7734c8793f0aa6e8d29889
Gerrit-Change-Number: 21117
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-12798: Tolerate floationg point precision for regr intercept() TIMESTAMP test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21117 )
Change subject: IMPALA-12798: Tolerate floationg point precision for regr_intercept() TIMESTAMP test
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I937dec4cdf9557c9af7734c8793f0aa6e8d29889
Gerrit-Change-Number: 21117
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Mar 2024 00:59:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12798: Tolerate floationg point precision for regr intercept() TIMESTAMP test
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
pranav.lodha@cloudera.com has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/21117 )
Change subject: IMPALA-12798: Tolerate floationg point precision for regr_intercept() TIMESTAMP test
......................................................................
IMPALA-12798: Tolerate floationg point precision for regr_intercept()
TIMESTAMP test
The patch focuses on making sure that the regr_intercept() tests are
uniform across different systems by adding tolerance for floating
point precision.
Change-Id: I937dec4cdf9557c9af7734c8793f0aa6e8d29889
---
M testdata/workloads/functional-query/queries/QueryTest/aggregation.test
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/21117/2
--
To view, visit http://gerrit.cloudera.org:8080/21117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I937dec4cdf9557c9af7734c8793f0aa6e8d29889
Gerrit-Change-Number: 21117
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-12798: Tolerate floationg point precision for regr intercept() TIMESTAMP test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21117 )
Change subject: IMPALA-12798: Tolerate floationg point precision for regr_intercept() TIMESTAMP test
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10363/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I937dec4cdf9557c9af7734c8793f0aa6e8d29889
Gerrit-Change-Number: 21117
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 20:19:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12798: Tolerate floationg point precision for regr intercept() TIMESTAMP test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21117 )
Change subject: IMPALA-12798: Tolerate floationg point precision for regr_intercept() TIMESTAMP test
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/15447/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I937dec4cdf9557c9af7734c8793f0aa6e8d29889
Gerrit-Change-Number: 21117
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2024 19:51:51 +0000
Gerrit-HasComments: No