You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/19 05:58:09 UTC
[GitHub] [flink] twalthr opened a new pull request #13681: [FLINK-19672][connector-kafka] Merge connector-kafka-base and connector-kafka
twalthr opened a new pull request #13681:
URL: https://github.com/apache/flink/pull/13681
## What is the purpose of the change
Simplifies the code base by removing the `connector-kafka-base` module. It also updates table sources and sinks and removes base classes that are no longer useful.
## Brief change log
See commit messages.
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13681: [FLINK-19672][connector-kafka] Merge connector-kafka-base and connector-kafka
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13681:
URL: https://github.com/apache/flink/pull/13681#issuecomment-711660909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d6fe62818eceafeeb2757e9850469652d6675774",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7836",
"triggerID" : "d6fe62818eceafeeb2757e9850469652d6675774",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d6fe62818eceafeeb2757e9850469652d6675774 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7836)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13681: [FLINK-19672][connector-kafka] Merge connector-kafka-base and connector-kafka
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13681:
URL: https://github.com/apache/flink/pull/13681#issuecomment-711660909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d6fe62818eceafeeb2757e9850469652d6675774",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7836",
"triggerID" : "d6fe62818eceafeeb2757e9850469652d6675774",
"triggerType" : "PUSH"
}, {
"hash" : "d6fe62818eceafeeb2757e9850469652d6675774",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7862",
"triggerID" : "712095611",
"triggerType" : "MANUAL"
}, {
"hash" : "d6fe62818eceafeeb2757e9850469652d6675774",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7836",
"triggerID" : "712095611",
"triggerType" : "MANUAL"
}, {
"hash" : "dacce0ebed3ed0c0b6eef162b83f80b2d97cf3e4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7865",
"triggerID" : "dacce0ebed3ed0c0b6eef162b83f80b2d97cf3e4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d6fe62818eceafeeb2757e9850469652d6675774 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7862) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7836)
* dacce0ebed3ed0c0b6eef162b83f80b2d97cf3e4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7865)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13681: [FLINK-19672][connector-kafka] Merge connector-kafka-base and connector-kafka
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13681:
URL: https://github.com/apache/flink/pull/13681#issuecomment-711660909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d6fe62818eceafeeb2757e9850469652d6675774",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d6fe62818eceafeeb2757e9850469652d6675774",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d6fe62818eceafeeb2757e9850469652d6675774 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #13681: [FLINK-19672][connector-kafka] Merge connector-kafka-base and connector-kafka
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13681:
URL: https://github.com/apache/flink/pull/13681#issuecomment-712008666
LGTM! This looks very straightforward, only moves code around. The only thing I'd be skeptical about is moving the state classes but you managed to keep them in the same package, so that's fine.
Also, I would move the deprecation to a separate commit, at least.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13681: [FLINK-19672][connector-kafka] Merge connector-kafka-base and connector-kafka
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13681:
URL: https://github.com/apache/flink/pull/13681#issuecomment-711660909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d6fe62818eceafeeb2757e9850469652d6675774",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7836",
"triggerID" : "d6fe62818eceafeeb2757e9850469652d6675774",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d6fe62818eceafeeb2757e9850469652d6675774 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7836)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13681: [FLINK-19672][connector-kafka] Merge connector-kafka-base and connector-kafka
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13681:
URL: https://github.com/apache/flink/pull/13681#issuecomment-711660909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d6fe62818eceafeeb2757e9850469652d6675774",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7836",
"triggerID" : "d6fe62818eceafeeb2757e9850469652d6675774",
"triggerType" : "PUSH"
}, {
"hash" : "d6fe62818eceafeeb2757e9850469652d6675774",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7862",
"triggerID" : "712095611",
"triggerType" : "MANUAL"
}, {
"hash" : "d6fe62818eceafeeb2757e9850469652d6675774",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7836",
"triggerID" : "712095611",
"triggerType" : "MANUAL"
}, {
"hash" : "dacce0ebed3ed0c0b6eef162b83f80b2d97cf3e4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7865",
"triggerID" : "dacce0ebed3ed0c0b6eef162b83f80b2d97cf3e4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dacce0ebed3ed0c0b6eef162b83f80b2d97cf3e4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7865)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13681: [FLINK-19672][connector-kafka] Merge connector-kafka-base and connector-kafka
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13681:
URL: https://github.com/apache/flink/pull/13681#issuecomment-711660909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d6fe62818eceafeeb2757e9850469652d6675774",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7836",
"triggerID" : "d6fe62818eceafeeb2757e9850469652d6675774",
"triggerType" : "PUSH"
}, {
"hash" : "d6fe62818eceafeeb2757e9850469652d6675774",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7862",
"triggerID" : "712095611",
"triggerType" : "MANUAL"
}, {
"hash" : "d6fe62818eceafeeb2757e9850469652d6675774",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7836",
"triggerID" : "712095611",
"triggerType" : "MANUAL"
}, {
"hash" : "dacce0ebed3ed0c0b6eef162b83f80b2d97cf3e4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7865",
"triggerID" : "dacce0ebed3ed0c0b6eef162b83f80b2d97cf3e4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d6fe62818eceafeeb2757e9850469652d6675774 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7862) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7836)
* dacce0ebed3ed0c0b6eef162b83f80b2d97cf3e4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7865)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13681: [FLINK-19672][connector-kafka] Merge connector-kafka-base and connector-kafka
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13681:
URL: https://github.com/apache/flink/pull/13681#issuecomment-711620661
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d6fe62818eceafeeb2757e9850469652d6675774 (Mon Oct 19 05:59:43 UTC 2020)
**Warnings:**
* **4 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on pull request #13681: [FLINK-19672][connector-kafka] Merge connector-kafka-base and connector-kafka
Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #13681:
URL: https://github.com/apache/flink/pull/13681#issuecomment-712095611
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13681: [FLINK-19672][connector-kafka] Merge connector-kafka-base and connector-kafka
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13681:
URL: https://github.com/apache/flink/pull/13681#issuecomment-711660909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d6fe62818eceafeeb2757e9850469652d6675774",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7836",
"triggerID" : "d6fe62818eceafeeb2757e9850469652d6675774",
"triggerType" : "PUSH"
}, {
"hash" : "d6fe62818eceafeeb2757e9850469652d6675774",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7862",
"triggerID" : "712095611",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d6fe62818eceafeeb2757e9850469652d6675774 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7836) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7862)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13681: [FLINK-19672][connector-kafka] Merge connector-kafka-base and connector-kafka
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13681:
URL: https://github.com/apache/flink/pull/13681#issuecomment-711660909
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d6fe62818eceafeeb2757e9850469652d6675774",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7836",
"triggerID" : "d6fe62818eceafeeb2757e9850469652d6675774",
"triggerType" : "PUSH"
}, {
"hash" : "d6fe62818eceafeeb2757e9850469652d6675774",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7862",
"triggerID" : "712095611",
"triggerType" : "MANUAL"
}, {
"hash" : "d6fe62818eceafeeb2757e9850469652d6675774",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7836",
"triggerID" : "712095611",
"triggerType" : "MANUAL"
}, {
"hash" : "dacce0ebed3ed0c0b6eef162b83f80b2d97cf3e4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dacce0ebed3ed0c0b6eef162b83f80b2d97cf3e4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d6fe62818eceafeeb2757e9850469652d6675774 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7862) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7836)
* dacce0ebed3ed0c0b6eef162b83f80b2d97cf3e4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #13681: [FLINK-19672][connector-kafka] Merge connector-kafka-base and connector-kafka
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #13681:
URL: https://github.com/apache/flink/pull/13681
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org