You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/06/23 10:52:43 UTC

[GitHub] [ignite-3] sashapolo commented on a change in pull request #174: IGNITE-14408 Implement the Vault Service on top of RocksDB

sashapolo commented on a change in pull request #174:
URL: https://github.com/apache/ignite-3/pull/174#discussion_r656981153



##########
File path: modules/runner/src/main/java/org/apache/ignite/internal/app/IgnitionImpl.java
##########
@@ -177,7 +186,38 @@ else if (jsonStrBootstrapCfg != null)
 
         ackSuccessStart();
 
-        return new IgniteImpl(distributedTblMgr);
+        return new IgniteImpl(distributedTblMgr) {
+            @Override public void close() throws Exception {
+                super.close();
+
+                vaultMgr.close();

Review comment:
       indeed, why not...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org