[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3341: Replace panic in `datafusion-expr` crate

[GitBox <gi...@apache.org>]

andygrove commented on code in PR #3341:
URL: https://github.com/apache/arrow-datafusion/pull/3341#discussion_r962165210


##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -605,14 +605,12 @@ impl LogicalPlanBuilder {
         let mut join_on: Vec<(Column, Column)> = vec![];
         let mut filters: Option<Expr> = None;
         for (l, r) in &on {
-            if self.plan.schema().field_from_column(l).is_ok()
-                && right.schema().field_from_column(r).is_ok()
-                && can_hash(self.plan.schema().field_from_column(l).unwrap().data_type())
+            if right.schema().field_from_column(r).is_ok()

Review Comment:
   This looks like it has changed the semantics of the code. Previously if `field_from_column(l)` was an `Err` then a different code path would have been followed and with this change, there would be an error instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org