[jira] [Commented] (OFBIZ-11746) Enforce noninstantiability to ConfigXMLReader Class

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127230#comment-17127230 ] 

ASF subversion and git services commented on OFBIZ-11746:
---------------------------------------------------------

Commit 924df4b217d5d0284a691d5445cc06a45e2b47e4 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=924df4b ]

Improved: Enforce noninstantiability to ConfigXMLReader Class (#178)

(OFBIZ-11746)

Made class as final, added private constructor and corrected private data members as per naming convention.

> Enforce noninstantiability to ConfigXMLReader Class
> ---------------------------------------------------
>
>                 Key: OFBIZ-11746
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11746
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>
> - Make ConfigXMLReader class as final.
>  - Add a private constructor.
>  - Make the following public static variable as private.
> {code:java}
> public static final String MODULE = ConfigXMLReader.class.getName();
> public static final Path CONTROLLERXMLFILENAME = Paths.get("WEB-INF", "controller.xml");
> public static final RequestResponse emptyNoneRequestResponse = RequestResponse.createEmptyNoneRequestResponse();{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)